Re: [PATCH 0/2] Markers Implementation for RCU Tracing

["K. Prasad" <prasad@linux.vnet.ibm.com>]

On Thu, Nov 29, 2007 at 05:36:05PM -0800, Paul E. McKenney wrote:
> On Fri, Nov 30, 2007 at 12:11:28AM +0530, K. Prasad wrote:
> > Hi,
> > 	Please review the ensuing set of patches which convert the
> > existing RCU tracing mechanism for Preempt RCU and RCU Boost into
> > markers.
> > 
> > These patches are based upon the 2.6.24-rc2-rt1 kernel tree.
> > 
> > Along with marker transition, the RCU Tracing infrastructure has also
> > been modularised to be built as a kernel module, thereby enabling
> > runtime changes to the RCU Tracing infrastructure.
> > 
> > Patch [1/2] - Patch that converts the Preempt RCU tracing in
> > rcupreempt.c into markers.
> > 
> > Patch [1/2] - Patch that converts the Preempt RCU Boost tracing in
> > rcupreempt-boost.c into markers.
> 
> Looks good to me, though I do not pretend to understand the markers
> implementation.  I presume that the markers implementation forces the
> varargs usage -- though the markers do seem quite a bit nicer in allowing
> the formatting to be specified more naturally.
> 

Paul,
	Thanks for the quick review.
Yes, varargs are required for marker handlers even with fixed set of
arguments.

Ingo,
	Can you please include these patches in your rt patchset?

Thanks,
K.Prasad