Re: [PATCH x86/mm 01/11] x86-32 thread_struct.debugreg

Roland McGrath
2007-11-29T21:51:53Z

> thanks, i've merged your 11 patches - they passed a basic build and boot
> test as well.

Thanks!

> Roland, you've done a lot of gdb / strace / glibc development, what
> would you suggest for us to use as a ptrace regression checker? The
> problem is that ptrace is not normally used on a default bootup of a
> distro, and some of the ptrace features are really arcane. UML is an
> extensive ptrace user, so running it might be a good start, but do you
> know of any, more directed testsuite that is expected to hit all (or at
> least a substantial percentage of) the various ptrace features that we
> are affecting with these ptrace patches?

Jan Kratochvil has helped me a great deal with ptrace testing lately.
We have started to collect a small regression test suite, see
http://sourceware.org/systemtap/wiki/utrace/tests for pointers. That
has tests for individual problems that have come up, and not anything
exhaustive for testing all ptrace functionality. The gdb test suite
is moderately torturous and more or less the standard big smoke test.
UML is also a good test, though I have never been set up to verify
anything beyond "UML seems to boot far enough to complain I don't
have a userland filesystem for it".

Most of the changes I've submitted lately are just moving code around
and not changing its logic substantially. So for most iterations
I've been reaosnably confident after just a few quick smoke tests
with simple manual uses of strace and gdb.

Thanks,
Roland