Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

Roland McGrath
2007-11-29T22:29:52Z

> This didn't need to be implemented as a macro hence it shouldn't have been.

Ok.

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b3433e1..0000000 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -45,8 +45,10 @@
/*
* Determines whether a value may be installed in a segment register.
*/
-#define invalid_selector(value) \
- ((value) != 0 && ((value) & SEGMENT_RPL_MASK) != USER_RPL)
+static inline bool invalid_selector(u16 value)
+{
+ return unlikely(value != 0 && (value & SEGMENT_RPL_MASK) != USER_RPL);
+}

#ifdef CONFIG_X86_32