From: Greg KH <gregkh@suse.de>
To: rae l <crquan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.
Date: Sat, 1 Dec 2007 20:48:25 -0800 [thread overview]
Message-ID: <20071202044825.GA7004@suse.de> (raw)
In-Reply-To: <91b13c310712011231k3604214bx3559387c568cce09@mail.gmail.com>
On Sun, Dec 02, 2007 at 04:31:09AM +0800, rae l wrote:
> ---
> and I still have questions about this code:
> 1. Why here kern_mount is needed?
> Or the first time user space `mount -t sysfs` won't do that?
> 2. If root executes many mounts to mount sysfs on /sys and many other places,
> are there many instances of struct vfsmount those have only
> mnt_mountpoint different?
>
> For most common case, mount a virtual filesystem(proc, sysfs, ...) on
> multiple mounting point,
> how to handle it more efficiently?
>
> and where is a detailed explaination on kern_mount? could someone give
> some comments or documentation pointers on this?
See the patches that Eric Biederman just posted to lkml for why this
structure is a static pointer this way right now, it's in preparation
for future patches.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2007-12-02 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-01 20:31 Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable rae l
2007-12-02 4:48 ` Greg KH [this message]
2007-12-02 6:52 ` rae l
2007-12-02 7:54 ` Greg KH
2007-12-02 22:22 ` Eric W. Biederman
2007-12-02 22:53 ` Greg KH
2007-12-03 0:46 ` Kay Sievers
2007-12-03 1:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202044825.GA7004@suse.de \
--to=gregkh@suse.de \
--cc=crquan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox