public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Thomas Tuttle <linux-kernel@ttuttle.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Oops with 2.6.24 git when loading iwl3945
Date: Sun, 2 Dec 2007 19:43:16 +0300	[thread overview]
Message-ID: <20071202164316.GB7377@cvg> (raw)
In-Reply-To: <1196196237.19410.1223544787@webmail.messagingengine.com>

[Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| Hey.
| 
| I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| fairly confident it's current), and I'm getting an Oops when I try to
| load the iwl3945 driver.  I've attached it as plain text.
| 
| Hope this helps,
| 
| Thomas Tuttle

Hi Thomas,
Could you please test the patch?

		Cyrill
---

Seems just mutex unlock is missed ;)

 net/mac80211/ieee80211_rate.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
index 7254bd6..3260a4a 100644
--- a/net/mac80211/ieee80211_rate.c
+++ b/net/mac80211/ieee80211_rate.c
@@ -33,6 +33,7 @@ int ieee80211_rate_control_register(struct rate_control_ops *ops)
 		if (!strcmp(alg->ops->name, ops->name)) {
 			/* don't register an algorithm twice */
 			WARN_ON(1);
+			mutex_unlock(&rate_ctrl_mutex);
 			return -EALREADY;
 		}
 	}

  parent reply	other threads:[~2007-12-02 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 20:43 Oops with 2.6.24 git when loading iwl3945 Thomas Tuttle
2007-11-28  5:48 ` Andrew Morton
2007-11-28 21:43   ` Jeremy Fitzhardinge
2007-11-28 23:50 ` Rafael J. Wysocki
2007-12-02 16:43 ` Cyrill Gorcunov [this message]
2007-12-02 17:46   ` Thomas Tuttle
2007-12-02 18:05     ` Cyrill Gorcunov
2007-12-03  5:25     ` Cyrill Gorcunov
2007-12-03 19:19     ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071202164316.GB7377@cvg \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@ttuttle.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox