From: Andrew Morton <akpm@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
mmlnx@us.ibm.com, dipankar@in.ibm.com, dsmith@redhat.com,
paulmck@us.ibm.com
Subject: Re: [patch 1/2] Linux Kernel Markers - Support Multiple Probes
Date: Tue, 4 Dec 2007 11:39:54 -0800 [thread overview]
Message-ID: <20071204113954.c1dc9d87.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071204192100.GB31752@Krystal>
On Tue, 4 Dec 2007 14:21:00 -0500
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> > > + */
> > > +void marker_probe_cb(const struct marker *mdata, void *call_private,
> > > + const char *fmt, ...)
> > > +{
> > > + va_list args;
> > > + char ptype;
> > > +
> > > + preempt_disable();
> >
> > What are the preempt_disable()s doing in here?
> >
> > Unless I missed something obvious, a comment is needed here (at least).
> >
>
> They make sure the teardown of the callbacks can be done correctly when
> they are in modules and they insure RCU read coherency. Will add
> comment.
So shouldn't it be using rcu_read_lock()? If that does not suit, should we
be adding new rcu primitives rather than open-coding and adding dependencies?
next prev parent reply other threads:[~2007-12-04 19:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 18:18 [patch 0/2] Linux Kernel Markers updates Mathieu Desnoyers
2007-12-04 18:18 ` [patch 1/2] Linux Kernel Markers - Support Multiple Probes Mathieu Desnoyers
2007-12-04 18:55 ` Christoph Hellwig
2007-12-04 20:03 ` Frank Ch. Eigler
2007-12-04 19:06 ` Andrew Morton
2007-12-04 19:21 ` Mathieu Desnoyers
2007-12-04 19:39 ` Andrew Morton [this message]
2007-12-04 19:45 ` Mathieu Desnoyers
2007-12-17 17:40 ` Paul E. McKenney
2007-12-20 14:25 ` Mathieu Desnoyers
2007-12-21 17:18 ` Paul E. McKenney
2007-12-17 18:45 ` Paul E. McKenney
2007-12-20 15:09 ` Mathieu Desnoyers
2007-12-04 18:18 ` [patch 2/2] Linux Kernel Markers - Create modpost file Mathieu Desnoyers
2007-12-04 18:57 ` Christoph Hellwig
2007-12-04 19:10 ` Andrew Morton
2007-12-04 19:15 ` Mathieu Desnoyers
2007-12-04 19:22 ` Christoph Hellwig
2007-12-04 21:34 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204113954.c1dc9d87.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dsmith@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mmlnx@us.ibm.com \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox