From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbXLDMia (ORCPT ); Tue, 4 Dec 2007 07:38:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753234AbXLDMiX (ORCPT ); Tue, 4 Dec 2007 07:38:23 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:51325 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023AbXLDMiX (ORCPT ); Tue, 4 Dec 2007 07:38:23 -0500 Date: Tue, 4 Dec 2007 13:38:09 +0100 From: Ingo Molnar To: Joerg Roedel Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Message-ID: <20071204123809.GD27286@elte.hu> References: <11966016811565-git-send-email-joerg.roedel@amd.com> <11966016814058-git-send-email-joerg.roedel@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11966016814058-git-send-email-joerg.roedel@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0002] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Joerg Roedel wrote: > +#define _PAGE_PRESENT (_AC(1,UL)<<_PAGE_BIT_PRESENT) please run patches through scripts/checkpatch.pl, it gives: total: 10 errors, 0 warnings, 42 lines checked (please send a followup cleanup patch - i picked up your series and this is a minor cleanliness issue) Ingo