From: Ingo Molnar <mingo@elte.hu>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
Jarek Poplawski <jarkao2@o2.pl>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: Need lockdep help
Date: Tue, 4 Dec 2007 22:00:06 +0100 [thread overview]
Message-ID: <20071204210006.GE32018@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0712041000540.4321-100000@iolanthe.rowland.org>
* Alan Stern <stern@rowland.harvard.edu> wrote:
> > I'm not sure I can understand your plan, but I doubt there should be
> > such problems with taking rwsem for sleeping, so maybe it would be
> > better to figure out what really scares lockdep, to fix the right
> > place?
>
> The real problem is that lockdep has to make some generalizations. It
> can't be aware of the details of every possible situation, and it
> doesn't have a global view of the entire kernel, so it doesn't know
> when special circumstances make deadlock impossible.
>
> Furthermore, in this case deadlock isn't really impossible -- it could
> occur if there were a bug somewhere else in the kernel. So lockdep
> was correct to warn that deadlock might occur.
ok. Thanks for resolving this by working it around - i _think_ in the
long run we'd like to make all locking "simpler" - not just for the sake
of lockdep, but also for the sake of human reviewability. So in that
sense, even though in this particular case you are fully right that
lockdep was wrong, we benefit long-term.
Ingo
prev parent reply other threads:[~2007-12-04 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 19:45 Need lockdep help Alan Stern
2007-12-02 20:04 ` Arjan van de Ven
2007-12-02 20:08 ` Alan Stern
2007-12-03 10:36 ` Jarek Poplawski
2007-12-03 15:08 ` Alan Stern
2007-12-03 23:25 ` Jarek Poplawski
2007-12-04 15:17 ` Alan Stern
2007-12-04 19:02 ` Jarek Poplawski
2007-12-04 19:28 ` Alan Stern
2007-12-04 20:14 ` Jarek Poplawski
2007-12-04 21:00 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204210006.GE32018@elte.hu \
--to=mingo@elte.hu \
--cc=jarkao2@gmail.com \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox