Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_*

Ingo Molnar
2007-12-05T11:28:20Z

* Joerg Roedel <joerg.roedel@amd.com> wrote:

> > > > please run patches through scripts/checkpatch.pl, it gives:
> > > >
> > > > total: 10 errors, 0 warnings, 42 lines checked
> > > >
> > > > (please send a followup cleanup patch - i picked up your series and this
> > > > is a minor cleanliness issue)
> > >
> > > Sorry, forgot to check the patches before submission. Will cleanup and
> > > resubmit soon.
> >
> > please if possible send a delta against x86.git, not a replacement
> > patch. It's easier for the patchflow.
>
> Not sure I understand you right here. Do you mean a patch on top of my
> previous patches?

yeah - that's easier to pick up for me (because i've already got your
series applied), and it's also easier for you as well. It also makes
sense to generally split style fixes from substantial patches. (in the
cases where there are pre-existing style problems in the code)

Ingo