Re: [PATCH] x86_64: some whitespace cleanups in paging code

Heiko Carstens
2007-12-05T16:37:37Z

On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> This patch does some whitespace cleanups in the paging code to fix some
> checkpatch.pl warnings of my formerly merged cleanup patches.
>...
> - set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> + set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));

Did checkpatch enforce you to remove the spaces around '+'? I thought
there was/is a common consensus that having spaces around operators is a good
thing to have. IMHO it's much more readable...
But anyway, it's not that I want to start a new thread about coding style :)