Re: [PATCH] x86_64: some whitespace cleanups in paging code

Joerg Roedel
2007-12-05T17:28:30Z

On Wed, Dec 05, 2007 at 05:37:24PM +0100, Heiko Carstens wrote:
> On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> > This patch does some whitespace cleanups in the paging code to fix some
> > checkpatch.pl warnings of my formerly merged cleanup patches.
> >...
> > - set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> > + set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
>
> Did checkpatch enforce you to remove the spaces around '+'? I thought
> there was/is a common consensus that having spaces around operators is a good
> thing to have. IMHO it's much more readable...
> But anyway, it's not that I want to start a new thread about coding style :)

Checkpatch complained about a missing space after the comma. After I
added one it complained about a line longer than 80 characters. But
luckily it didn't complain about missing spaces around the plus sign ;)

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy