From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] x86_64: some whitespace cleanups in paging code
Date: Wed, 5 Dec 2007 17:37:24 +0100 [thread overview]
Message-ID: <20071205163724.GA1024@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1196865612128-git-send-email-joerg.roedel@amd.com>
On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> This patch does some whitespace cleanups in the paging code to fix some
> checkpatch.pl warnings of my formerly merged cleanup patches.
>...
> - set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> + set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
Did checkpatch enforce you to remove the spaces around '+'? I thought
there was/is a common consensus that having spaces around operators is a good
thing to have. IMHO it's much more readable...
But anyway, it's not that I want to start a new thread about coding style :)
next prev parent reply other threads:[~2007-12-05 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 13:21 [PATCH 0/3] x86_64: some minor paging cleanups Joerg Roedel
2007-12-02 13:21 ` [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Joerg Roedel
2007-12-04 12:36 ` Ingo Molnar
2007-12-04 12:38 ` Ingo Molnar
2007-12-04 15:06 ` Joerg Roedel
2007-12-04 21:07 ` Ingo Molnar
2007-12-05 10:52 ` Joerg Roedel
2007-12-05 11:27 ` Ingo Molnar
2007-12-05 11:42 ` Joerg Roedel
2007-12-05 12:30 ` Ingo Molnar
2007-12-05 14:40 ` [PATCH] x86_64: some whitespace cleanups in paging code Joerg Roedel
2007-12-05 14:51 ` Ingo Molnar
2007-12-05 16:37 ` Heiko Carstens [this message]
2007-12-05 17:24 ` Joerg Roedel
2007-12-02 13:21 ` [PATCH 2/3] x86_64: use __PAGE_KERNEL* instead of _KERNPG_TABLE for 2MB PTEs in memory initialization Joerg Roedel
2007-12-02 13:21 ` [PATCH 3/3] x86_64: use __PAGE_KERNEL_EXEC in ioremap_64.c Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205163724.GA1024@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=apw@shadowen.org \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox