From: Rusty Russell <rusty@rustcorp.com.au>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
Paulo Marques <pmarques@grupopie.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [-mm PATCH] kallsyms should prefer non weak symbols
Date: Wed, 5 Dec 2007 20:37:08 +1100 [thread overview]
Message-ID: <200712052037.09425.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20071204223123.GA11100@Krystal>
On Wednesday 05 December 2007 09:31:23 Mathieu Desnoyers wrote:
> * Arjan van de Ven (arjan@infradead.org) wrote:
> > On Tue, 04 Dec 2007 20:35:32 +0000
> >
> > Paulo Marques <pmarques@grupopie.com> wrote:
> > > When resolving symbol names from addresses with aliased symbol names,
> > > kallsyms_lookup always returns the first symbol, even if it is a weak
> > > symbol.
> > >
> > > This patch changes this by sorting the symbols with the weak symbols
> > > last before feeding them to the kernel. This way the kernel runtime
> > > isn't changed at all, only the kallsyms build system is changed.
> >
> > what user of this api is affected by this?
>
> grep -r kallsyms_lookup * does a pretty good job at it ;)
Yeah, we discussed this before and agreed it was best to show strong symbols
before weak ones.
Cheers,
Rusty.
next prev parent reply other threads:[~2007-12-05 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 20:35 [-mm PATCH] kallsyms should prefer non weak symbols Paulo Marques
2007-12-04 21:14 ` Mathieu Desnoyers
2007-12-05 12:07 ` Paulo Marques
2007-12-04 21:17 ` Andrew Morton
2007-12-04 21:38 ` Mathieu Desnoyers
2007-12-04 21:34 ` Arjan van de Ven
2007-12-04 22:31 ` Mathieu Desnoyers
2007-12-05 9:37 ` Rusty Russell [this message]
2007-12-05 2:05 ` Rusty Russell
2007-12-05 3:09 ` Andrew Morton
2007-12-05 3:14 ` Andrew Morton
2007-12-05 5:01 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712052037.09425.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=compudj@krystal.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox