From: Konrad Rzeszutek <konrad@darnok.org>
To: Doug Maxey <dwm@enoyolf.org>
Cc: darnok@68k.org, linux-kernel@vger.kernel.org, pjones@redhat.com,
konradr@redhat.com, konradr@linux.vnet.ibm.com, greg@kroah.com,
randy.dunlap@oracle.com, hpa@zytor.com, lenb@kernel.org,
mike.anderson@us.ibm.com, dwm@austin.ibm.com,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)
Date: Wed, 5 Dec 2007 16:40:46 -0400 [thread overview]
Message-ID: <20071205204046.GA2898@andromeda.dapyr.net> (raw)
In-Reply-To: <1797.1196886400@bebe.enoyolf.org>
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
>
> On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > Is the current include from open-iscsi being duplicated? If not, why
> > > not consolidate in one file?
> >
> > The include files that come from open-iscsi that are in the kernel do
> > not have the iBFT data structures in them - therefore no duplication.
>
> That is strictly true, at least the "in the kernel" part. There is a
> file with the definitions, open-iscsi utils/fwparam_ibft/fwparam_ibft.h
> does have the previous definitons. So what to do? Drop that one? Or
> keep duplicating?
I would say that utils/fwparam_ibft/fwparam_ibft.h and
utils/fwparam_ibft/fwparam_ibft.c would be dropped once this kernel
patch and the patch to open-iscsi to add fwparam_ibft_subsys.c are
reviewed and hopefully accepted.
next prev parent reply other threads:[~2007-12-05 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 23:34 [REPOST PATCH] Add iSCSI IBFT support (v0.4) Konrad Rzeszutek
2007-12-05 0:44 ` darnok
2007-12-05 3:12 ` Doug Maxey
2007-12-05 17:41 ` Konrad Rzeszutek
2007-12-05 20:26 ` Doug Maxey
2007-12-05 20:40 ` Konrad Rzeszutek [this message]
2007-12-05 21:02 ` Doug Maxey
2007-12-05 21:18 ` Konrad Rzeszutek
2007-12-05 19:47 ` [PATCH] Add iSCSI IBFT support (v0.4.2) Konrad Rzeszutek
2007-12-21 20:05 ` Greg KH
2007-12-21 21:01 ` [PATCH] Add iSCSI IBFT support (v0.4.3) Konrad Rzeszutek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205204046.GA2898@andromeda.dapyr.net \
--to=konrad@darnok.org \
--cc=arjan@infradead.org \
--cc=darnok@68k.org \
--cc=dwm@austin.ibm.com \
--cc=dwm@enoyolf.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=konradr@linux.vnet.ibm.com \
--cc=konradr@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.anderson@us.ibm.com \
--cc=pjones@redhat.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox