From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbXLEUnV (ORCPT ); Wed, 5 Dec 2007 15:43:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751593AbXLEUnN (ORCPT ); Wed, 5 Dec 2007 15:43:13 -0500 Received: from andromeda.dapyr.net ([206.212.254.10]:55401 "EHLO andromeda.dapyr.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbXLEUnN (ORCPT ); Wed, 5 Dec 2007 15:43:13 -0500 Date: Wed, 5 Dec 2007 16:40:46 -0400 From: Konrad Rzeszutek To: Doug Maxey Cc: darnok@68k.org, linux-kernel@vger.kernel.org, pjones@redhat.com, konradr@redhat.com, konradr@linux.vnet.ibm.com, greg@kroah.com, randy.dunlap@oracle.com, hpa@zytor.com, lenb@kernel.org, mike.anderson@us.ibm.com, dwm@austin.ibm.com, Arjan van de Ven Subject: Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4) Message-ID: <20071205204046.GA2898@andromeda.dapyr.net> References: <20071128233422.GD6736@andromeda.dapyr.net> <20071205004418.GH6736@andromeda.dapyr.net> <22081.1196824331@bebe.enoyolf.org> <20071205174121.GA1801@andromeda.dapyr.net> <1797.1196886400@bebe.enoyolf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1797.1196886400@bebe.enoyolf.org> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > Is the current include from open-iscsi being duplicated? If not, why > > > not consolidate in one file? > > > > The include files that come from open-iscsi that are in the kernel do > > not have the iBFT data structures in them - therefore no duplication. > > That is strictly true, at least the "in the kernel" part. There is a > file with the definitions, open-iscsi utils/fwparam_ibft/fwparam_ibft.h > does have the previous definitons. So what to do? Drop that one? Or > keep duplicating? I would say that utils/fwparam_ibft/fwparam_ibft.h and utils/fwparam_ibft/fwparam_ibft.c would be dropped once this kernel patch and the patch to open-iscsi to add fwparam_ibft_subsys.c are reviewed and hopefully accepted.