From: Nick Piggin <npiggin@suse.de>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: akpm@linux-foundation.org, paolo.abeni@email.it,
linux-kernel@vger.kernel.org
Subject: Re: [patch 12/18] usb: mon nopage
Date: Thu, 6 Dec 2007 00:54:01 +0100 [thread overview]
Message-ID: <20071205235401.GF5617@wotan.suse.de> (raw)
In-Reply-To: <20071205083925.c4a8ca64.zaitcev@redhat.com>
On Wed, Dec 05, 2007 at 08:39:25AM -0800, Pete Zaitcev wrote:
> On Wed, 05 Dec 2007 18:15:59 +1100, npiggin@suse.de wrote:
>
> > Convert USB mon driver from nopage to fault.
>
> > if (offset >= rp->b_size)
> > - return NOPAGE_SIGBUS;
> > + return VM_FAULT_SIGBUS;
> > chunk_idx = offset / CHUNK_SIZE;
> > pageptr = rp->b_vec[chunk_idx].pg;
> > get_page(pageptr);
> > - if (type)
> > - *type = VM_FAULT_MINOR;
> > - return pageptr;
> > + vmf->page = pageptr;
> > + return 0;
>
> Looks like a trivial change, I ack this. It's a rarely used API, I have
> to run tests to see how it works. I'll collect any failing pieces later
> if any.
That would be great, thanks.
> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
>
> -- Pete
next prev parent reply other threads:[~2007-12-05 23:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 7:15 [patch 00/18] remove nopage npiggin
2007-12-05 7:15 ` [patch 01/18] ia64: ia32 nopage npiggin
2007-12-05 7:15 ` [patch 02/18] relay: nopage npiggin
2007-12-05 7:15 ` [patch 03/18] drm: nopage npiggin
2007-12-05 9:05 ` Dave Airlie
2007-12-05 9:17 ` Nick Piggin
2007-12-05 7:15 ` [patch 04/18] uio: nopage npiggin
2007-12-05 10:04 ` Hans-Jürgen Koch
2007-12-05 10:10 ` Nick Piggin
2007-12-05 10:25 ` Hans-Jürgen Koch
2007-12-05 10:37 ` Nick Piggin
2007-12-05 7:15 ` [patch 05/18] kvm: nopage npiggin
2007-12-05 10:40 ` Avi Kivity
2007-12-05 7:15 ` [patch 06/18] ieee1394: nopage npiggin
2007-12-05 13:09 ` Stefan Richter
2007-12-05 13:15 ` Stefan Richter
2007-12-05 23:52 ` Nick Piggin
2007-12-05 23:51 ` Nick Piggin
2007-12-15 13:04 ` Stefan Richter
2007-12-15 13:01 ` Stefan Richter
2007-12-05 7:15 ` [patch 07/18] v4l: nopage npiggin
2007-12-08 0:31 ` Andrew Morton
2007-12-08 9:15 ` Ingo Molnar
2007-12-08 10:15 ` Andrew Morton
2007-12-09 17:10 ` Randy Dunlap
2007-12-10 5:06 ` [patch] x64/page.h: convert some macros to inlines Randy Dunlap
2007-12-10 8:34 ` Ingo Molnar
2007-12-05 7:15 ` [patch 08/18] fb: defio nopage npiggin
2007-12-05 7:15 ` [patch 09/18] agp: alpha nopage npiggin
2007-12-05 7:15 ` [patch 10/18] sg: nopage npiggin
2008-02-08 3:45 ` Douglas Gilbert
2007-12-05 7:15 ` [patch 11/18] ib: nopage npiggin
2007-12-05 7:15 ` [patch 12/18] usb: mon nopage npiggin
2007-12-05 16:39 ` Pete Zaitcev
2007-12-05 23:54 ` Nick Piggin [this message]
2007-12-05 7:16 ` [patch 13/18] alsa: nopage npiggin
2007-12-13 15:35 ` Takashi Iwai
2007-12-05 7:16 ` [patch 14/18] oss: via nopage npiggin
2007-12-05 7:16 ` [patch 15/18] alsa: usx2y nopage npiggin
2007-12-13 15:35 ` Takashi Iwai
2007-12-05 7:16 ` [patch 16/18] mm: special mapping nopage npiggin
2007-12-05 7:16 ` [patch 17/18] mm: remove nopage npiggin
2007-12-05 22:47 ` Andrew Morton
2007-12-05 23:23 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205235401.GF5617@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.abeni@email.it \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox