public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Andrew Victor <linux@maxim.org.za>,
	Patrice VILCHEZ <patrice.vilchez@atmel.com>,
	ARM Linux Mailing List  <linux-arm-kernel@lists.arm.linux.org.uk>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: at91_udc: correct hanging while disconnecting usb cable
Date: Thu, 6 Dec 2007 08:02:52 -0800	[thread overview]
Message-ID: <200712060802.53229.david-b@pacbell.net> (raw)
In-Reply-To: <4757D7F3.8040904@atmel.com>

On Thursday 06 December 2007, Nicolas Ferre wrote:
> Correct hanging while disconnecting the USB device 
> cable. Prevent a race between vbus and UDP interrupts.
> This bug was tracked on at91sam9260ek boards.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@rfo.atmel.com> 
> ---
> 
> A usb resume interrupt was firing after the vbus 
> interrupt : the IP was then already stoped and not able 
> to deal with it (no more clock). A simple interrupt disabling 
> is ok as the "end of bus reset" irq is non maskable and ok 
> to resume the USB device IP.

Good, thanks for finding this.  The bug was reported
recently, and obviously can't be reproduced except on
boards which *have* a VBUS interrupt!

I've signed off on this and suggested Greg merge it
before the 2.6.24-final freeze.

- Dave

      reply	other threads:[~2007-12-06 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 11:07 [PATCH] usb: at91_udc: correct hanging while disconnecting usb cable Nicolas Ferre
2007-12-06 16:02 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712060802.53229.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@atmel.com \
    --cc=patrice.vilchez@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox