Re: 2.6.24-rc4-mm1

Randy Dunlap
2007-12-11T17:01:19Z

On Tue, 11 Dec 2007 08:20:05 -0800 Martin Bligh wrote:

> > - Lots of device IDs have been removed from the e1000 driver and
> > moved over to e1000e. So if your e1000 stops working, you forgot
> > to set CONFIG_E1000E.
>
>
> Wouldn't it make sense to just default this to on if E1000 was on?
> As far as I can see that's not true, which will screwing everybody
> for no good reason (plus breaking all the automated testing, etc etc)?
> Much though I love random refactoring, it is fairly painful to just
> keep changing the names of things.
>
>
> I can't see this compile failure posted anywhere:
> http://test.kernel.org/results/IBM/126049/build/debug/stderr
>
> arch/x86/vdso/vdso32/sigreturn.S: Assembler messages:
> arch/x86/vdso/vdso32/sigreturn.S:23: Error: suffix or operands invalid
> for `pop'
>
> arch/x86/vdso/vdso32/syscall.S:25: Error: suffix or operands invalid for
> `pop'
> make[1]: *** [arch/x86/vdso/vdso32/syscall.o] Error 1
> make: *** [arch/x86/vdso] Error 2

I see those on one build machine but not on another, so I thought
that it was a tools issue...

> Nor this one:
> http://test.kernel.org/results/IBM/126096/build/debug/stderr
>
> drivers/char/hvcs.c: In function ‘hvcs_open’:
> drivers/char/hvcs.c:1180: error: wrong type argument to unary
> exclamation mark

See http://marc.info/?l=linux-kernel&m=119700448119646
for patches.

---
~Randy
Features and documentation: http://lwn.net/Articles/260136/