From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/6] UML - Customize tlb.h
Date: Thu, 6 Dec 2007 15:19:29 -0500 [thread overview]
Message-ID: <20071206201929.GA9366@c2.user-mode-linux.org> (raw)
In-Reply-To: <20071206114642.555a0749.akpm@linux-foundation.org>
On Thu, Dec 06, 2007 at 11:46:42AM -0800, Andrew Morton wrote:
> > +void flush_tlb_mm(struct mm_struct *mm)
> > +{
> > + struct vm_area_struct *vma = mm->mmap;
> > +
> > + if (atomic_read(&mm->mm_users) == 0)
> > + return;
>
> Under which circumstances does this test succeed?
Sigh, none. The other copy obviously succeeds during exit - this one
isn't needed.
> This file rather needs an inclusion of percpu.h. I guess you got
> lucky.
Yup, drop this, and I'll send a fixed version.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2007-12-06 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 17:06 [PATCH 1/6] UML - Customize tlb.h Jeff Dike
2007-12-06 19:46 ` Andrew Morton
2007-12-06 20:19 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206201929.GA9366@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox