From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.23: x86_64 oops caused by hotplug running before vdso initialized
Date: Thu, 6 Dec 2007 21:51:55 +0100 [thread overview]
Message-ID: <200712062151.55480.ak@suse.de> (raw)
In-Reply-To: <4758512E.1060306@redhat.com>
On Thursday 06 December 2007 20:44:46 Chuck Ebbert wrote:
> pages is NULL here, implying vma->vm_private_data was NULL. This is apparently
> because init_vdso_vars() is __initcall and runs after the rootfs gets populated.
> An experimental initrd containing an /sbin/hotplug binary caused this. Normally
> we don't have that file in the initrd. Should vdso init be done earlier to prevent
> this problem?
We've often had bugs like this. Sure it could be fixed here, but then
the next bug would crop up again later I bet.
It would be better to move the first user space code execution later I think.
I guess the hotplug events could be delayed or initrd just mounted later.
Running any user space before __initcall() has finished is just wrong.
-Andi
next prev parent reply other threads:[~2007-12-06 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:44 2.6.23: x86_64 oops caused by hotplug running before vdso initialized Chuck Ebbert
2007-12-06 20:51 ` Andi Kleen [this message]
2007-12-06 21:10 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712062151.55480.ak@suse.de \
--to=ak@suse.de \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox