Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

Yinghai Lu
2007-12-11T18:45:33Z

On Dec 11, 2007 10:29 AM, Neil Horman <nhorman@tuxdriver.com> wrote:
>
> On Tue, Dec 11, 2007 at 10:00:00AM -0800, Yinghai Lu wrote:
> > On Dec 11, 2007 7:29 AM, Eric W. Biederman <ebiederm@xmission.com> wrote:
> > >
> > > I'm actually inclined to remove the return magic and just do something
> > > like:
> > > static fix_applied;
> > > if (fix_applied++)
> > > return;
> > > In those functions that should be called only once.
> >
> > it seems we need to have two tables. one for northbridge (sweep all
> > the NB_K8) and another for SB ( like Nvidia, ati..., one touch and
> > leave)
> >
> > YH
> >
> I like Erics idea better I think. My origional patch had two tables, and it
> seems that it made the early quirk detection logic that much more convoluted.
> This way each quirk can determine if it needs to be applied to more than one pci
> device.
>

nvidia or ati chip will come first, and then amd NB ( K8). So you need
to make sure "fix_applied return" is not going to skip your fix to
K8_NB.

YH