Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

Eric W. Biederman
2007-12-18T00:23:37Z

Andi Kleen <andi@firstfloor.org> writes:

> On Thu, Dec 13, 2007 at 09:39:22AM -0500, Neil Horman wrote:
>>
>> Ok, new patch attached, taking into account Andi's request for a cleaner
> method
>
> Sorry for not noticing that earlier, but was there a specific reason this needs
> to be an early quirk at all? kexec can only happen after the standard quirks
> ran.
> I think it should be fine as a standard "late" quirk.

Just to document things. The important thing is this quirk happens
before calibrate_delay(). Which is still before the normal pci
subsystem gets initialized. So that seems to require an early_quirk
as the pci subsystem is not initialized by that point.

The only case we are likely to hit this is kdump because BIOS almost
always boot us on the cpu with apic id == 0. However in the case
of this bug if we happen to boot on a cpu with apic id >= 16 we
won't be able to boot the linux kernel either, because calibrate_delay
will fail.

Eric