* [PATCH] ps3: "mm/Kconfig" fix
@ 2007-12-08 19:30 Miguel Botón
2007-12-08 20:06 ` Miguel Botón
2007-12-09 2:34 ` Geoff Levand
0 siblings, 2 replies; 3+ messages in thread
From: Miguel Botón @ 2007-12-08 19:30 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Geoff Levand
sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.
SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the
architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled,
so SPARSEMEM_VMEMMAP should depend on it.
Signed-off-by: Miguel Botón <mboton@gmail.com>
diff --git a/mm/Kconfig b/mm/Kconfig
index c0f5cbb..010a261 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -117,8 +117,8 @@ config SPARSEMEM_VMEMMAP_ENABLE
config SPARSEMEM_VMEMMAP
bool "Sparse Memory virtual memmap"
- depends on SPARSEMEM
- default y if (SPARSEMEM_VMEMMAP_ENABLE)
+ depends on SPARSEMEM_VMEMMAP_ENABLE
+ default y
help
SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise
pfn_to_page and page_to_pfn operations. This is the most
--
Miguel Botón
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ps3: "mm/Kconfig" fix
2007-12-08 19:30 [PATCH] ps3: "mm/Kconfig" fix Miguel Botón
@ 2007-12-08 20:06 ` Miguel Botón
2007-12-09 2:34 ` Geoff Levand
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Botón @ 2007-12-08 20:06 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Geoff Levand
Previous patch had another bug. This one works fine.
Signed-off-by: Miguel Botón <mboton@gmail.com>
diff --git a/mm/Kconfig b/mm/Kconfig
index 010a261..9ef9741 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -117,7 +117,7 @@ config SPARSEMEM_VMEMMAP_ENABLE
config SPARSEMEM_VMEMMAP
bool "Sparse Memory virtual memmap"
- depends on SPARSEMEM_VMEMMAP_ENABLE
+ depends on SPARSEMEM && SPARSEMEM_VMEMMAP_ENABLE
default y
help
SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise
--
Miguel Botón
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ps3: "mm/Kconfig" fix
2007-12-08 19:30 [PATCH] ps3: "mm/Kconfig" fix Miguel Botón
2007-12-08 20:06 ` Miguel Botón
@ 2007-12-09 2:34 ` Geoff Levand
1 sibling, 0 replies; 3+ messages in thread
From: Geoff Levand @ 2007-12-09 2:34 UTC (permalink / raw)
To: Miguel Botón; +Cc: Linux Kernel Mailing List
On 12/08/2007 11:30 AM, Miguel Botón wrote:
> sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.
>
> SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the
> architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled,
> so SPARSEMEM_VMEMMAP should depend on it.
sparsemem-make-sparsemem-vmemmap-selectable.patch is still only in my
ps3-linux-patches.git development repo. I'll just fold this into the
original patch. Thanks.
-Geoff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-09 2:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-08 19:30 [PATCH] ps3: "mm/Kconfig" fix Miguel Botón
2007-12-08 20:06 ` Miguel Botón
2007-12-09 2:34 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox