From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: fpavlic@de.ibm.com, wangchen@cn.fujitsu.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] Fix use of skb after netif_rx
Date: Mon, 10 Dec 2007 17:17:59 -0800 (PST) [thread overview]
Message-ID: <20071210.171759.78444664.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712092103560.11165@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 9 Dec 2007 21:05:30 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> Recently, Wang Chen submitted a patch
> (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
> after a subsequent reference to skb, because netif_rx may call kfree_skb on
> its argument. netif_rx_ni calls netif_rx, so the same problem occurs in
> the files below.
>
> I have left the updating of dev->last_rx after the calls to netif_rx_ni
> because it seems time dependent, but moved the other field updates before.
>
> This was found using the following semantic match.
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
prev parent reply other threads:[~2007-12-11 1:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 20:05 [PATCH 3/3] Fix use of skb after netif_rx Julia Lawall
2007-12-10 2:28 ` Wang Chen
2007-12-10 7:18 ` Julia Lawall
2007-12-10 7:35 ` Wang Chen
2007-12-11 1:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210.171759.78444664.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fpavlic@de.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox