From: David Brownell <david-b@pacbell.net>
To: "eric miao" <eric.y.miao@gmail.com>
Cc: "Linux Kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
i2c@lm-sensors.org
Subject: Re: [PATCH 2.6.24-rc4-mm 2/2] gpiolib: add Generic IRQ support for 16-bit PCA9539 GPIO expander
Date: Mon, 10 Dec 2007 02:14:52 -0800 [thread overview]
Message-ID: <200712100214.52478.david-b@pacbell.net> (raw)
In-Reply-To: <f17812d70712100143w65898405rd96f460aef621a25@mail.gmail.com>
On Monday 10 December 2007, eric miao wrote:
> +config GPIO_PCA9539_GENERIC_IRQ
> + bool " Generic IRQ support for PCA9539"
> + depends on GPIO_PCA9539=y
Also depends on GENERIC_HARDIRQS, right? (You should let
the Kconfig UI handle indentation, too...)
Seems like doing this for an I2C chip ought to shake loose
some interesting review comments. :)
> + help
> + Say yes here to support the Generic IRQ for the PCA9539 on-chip
> + GPIO lines.
This somewhat resembles the pcf857x chips in that it only support
pin-changed IRQs (IRQ_TYPE_EDGE_BOTH) in hardware. Some other I/O
expanders are a bit more flexible.
- Dave
next prev parent reply other threads:[~2007-12-10 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 9:43 [PATCH 2.6.24-rc4-mm 2/2] gpiolib: add Generic IRQ support for 16-bit PCA9539 GPIO expander eric miao
2007-12-10 10:14 ` David Brownell [this message]
2007-12-11 2:28 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712100214.52478.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=eric.y.miao@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox