* [PATCH git-sched 1/3] no need for 'affine wakeup' balancing in select_task_rq_fair() when task_cpu(p) == this_cpu
@ 2007-12-09 18:36 Dmitry Adamushko
2007-12-10 8:37 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Adamushko @ 2007-12-09 18:36 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, Gregory Haskins, LKML Kernel
From: Dmitry Adamushko <dmitry.adamushko@gmail.com>
No need to do a check for 'affine wakeup and passive balancing possibilities' in
select_task_rq_fair() when task_cpu(p) == this_cpu.
I guess, this part got missed upon introduction of per-sched_class select_task_rq()
in try_to_wake_up().
Signed-off-by: Dmitry Adamushko <dmitry.adamushko@gmail.com>
---
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index f881fc5..2208692 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -925,6 +925,9 @@ static int select_task_rq_fair(struct task_struct *p, int sync)
this_cpu = smp_processor_id();
new_cpu = cpu;
+ if (cpu == this_cpu)
+ goto out_set_cpu;
+
for_each_domain(this_cpu, sd) {
if (cpu_isset(cpu, sd->span)) {
this_sd = sd;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH git-sched 1/3] no need for 'affine wakeup' balancing in select_task_rq_fair() when task_cpu(p) == this_cpu
2007-12-09 18:36 [PATCH git-sched 1/3] no need for 'affine wakeup' balancing in select_task_rq_fair() when task_cpu(p) == this_cpu Dmitry Adamushko
@ 2007-12-10 8:37 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2007-12-10 8:37 UTC (permalink / raw)
To: Dmitry Adamushko; +Cc: Steven Rostedt, Gregory Haskins, LKML Kernel
* Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:
> From: Dmitry Adamushko <dmitry.adamushko@gmail.com>
>
> No need to do a check for 'affine wakeup and passive balancing
> possibilities' in select_task_rq_fair() when task_cpu(p) == this_cpu.
>
> I guess, this part got missed upon introduction of per-sched_class
> select_task_rq() in try_to_wake_up().
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-10 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 18:36 [PATCH git-sched 1/3] no need for 'affine wakeup' balancing in select_task_rq_fair() when task_cpu(p) == this_cpu Dmitry Adamushko
2007-12-10 8:37 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox