Re: Please revert: PCI: fix IDE legacy mode resources

Ralf Baechle
2007-12-10T13:39:30Z

On Mon, Dec 10, 2007 at 03:29:22PM +1100, Benjamin Herrenschmidt wrote:

> To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
> Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>,
> Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>,
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
> Greg KH <gregkh@suse.de>,
> Linus Torvalds <torvalds@linux-foundation.org>,
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: Re: Please revert: PCI: fix IDE legacy mode resources
> Content-Type: text/plain
>
> powerpc: Fix IDE legacy vs. native fixups
>
> PowerMac and CHRP/BriQ platforms have quirks to switch some IDE
> controllers from legacy mode to fully native mode. Those quirks
> however will not work properly anymore due to a change to the
> generic code to better handle legacy IDE resources.
>
> This fixes it by moving those quirk to "early" quirks (so they
> run before resources are probed for the devices) and clearing
> all BARs after the conversion to force a reallocation of sane
> values.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> To be totally correct, we still need to also revert
> commit fd6e732186ab522c812ab19c2c5e5befb8ec8115 which
> is bogus.
>
> Linus, can you still apply this to 2.6.24 ? I would also like the
> above (fd6e...) reverted as so far, nobody have come up with a demonstration
> that it's not bogus.

For the revert:

Acked-by: Ralf Baechle <ralf@linux-mips.org>

I'll work with Yoichi to find another solution.

Ralf