Re: Please revert: PCI: fix IDE legacy mode resources

Benjamin Herrenschmidt
2007-12-09T20:11:59Z

On Sun, 2007-12-09 at 13:39 +0000, Alan Cox wrote:
> > > In fact, I see a deeper problem with Bart's original patch that moved
> > > the "fixup" the PCI probe.
> >
> > I don't remember changing anything there, could you remind me what it was
> > exactly (commit number or patch name)?
>
> I'm pretty sure he means the code I added a while ago to actually correct
> our IDE/ATA handling for legacy devices, fix the resource tree being
> wrong and remove tons of special cases from drivers.

Yup, that one, sorry Bart, I thought it was from you.

So far, a quirk grep shows such quirks only in powerpc code though, in
the chrp and powermac platforms (mostly the same one copied over). I'll
do a fix that re-allocate all resources on these instead (though I
suppose another option would be to just write the legacy addresses to
the BARs after turning it into native mode... probably even better).

Ben.