Re: Please revert: PCI: fix IDE legacy mode resources

Alan Cox
2007-12-10T11:28:51Z

On Mon, 10 Dec 2007 15:29:22 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> powerpc: Fix IDE legacy vs. native fixups
>
> PowerMac and CHRP/BriQ platforms have quirks to switch some IDE
> controllers from legacy mode to fully native mode. Those quirks
> however will not work properly anymore due to a change to the
> generic code to better handle legacy IDE resources.
>
> This fixes it by moving those quirk to "early" quirks (so they
> run before resources are probed for the devices) and clearing
> all BARs after the conversion to force a reallocation of sane
> values.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Acked-by: Alan Cox <alan@redhat.com>

> To be totally correct, we still need to also revert
> commit fd6e732186ab522c812ab19c2c5e5befb8ec8115 which
> is bogus.

Agreed but that would cause an revert on an obscure MIPS platform which
is apparently now a thoughtcrime ;)

> Linus, can you still apply this to 2.6.24 ? I would also like the
> above (fd6e...) reverted as so far, nobody have come up with a demonstration
> that it's not bogus.

Ack the revert too.

The MIPS needs sorting out differently.