Re: [PATCH 1/2] Kprobes: Indicate kretprobe support in arch//Kconfig

Sam Ravnborg
2007-12-10T10:11:31Z

On Mon, Dec 10, 2007 at 03:22:22PM +0530, Ananth N Mavinakayanahalli wrote:
> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>
> This patch adds CONFIG_HAVE_KRETPROBES to the arch/<arch>/Kconfig file
> for relevant architectures with kprobes support. This facilitates easy
> handling of in-kernel modules (like samples/kprobes/kretprobe_example.c)
> that depend on kretprobes being present in the kernel.
>
> This patch depends on Mathieu Desnoyers' "Instrumentation menu removal"
> patchset (http://marc.info/?l=linux-kernel&m=119496432229633&w=2)
>
> Updated to apply on 2.6.24-rc4-mm1.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> ---
> arch/avr32/Kconfig | 5 +++++
> arch/ia64/Kconfig | 5 +++++
> arch/powerpc/Kconfig | 5 +++++
> arch/s390/Kconfig | 5 +++++
> arch/sparc64/Kconfig | 5 +++++
> arch/x86/Kconfig | 5 +++++
> include/asm-ia64/kprobes.h | 1 -
> include/asm-powerpc/kprobes.h | 1 -
> include/asm-s390/kprobes.h | 1 -
> include/asm-x86/kprobes_32.h | 1 -
> include/asm-x86/kprobes_64.h | 1 -
> include/linux/kprobes.h | 6 +++---
> kernel/kprobes.c | 8 +++-----
> 13 files changed, 36 insertions(+), 13 deletions(-)
>
> Index: linux-2.6.24-rc4/arch/avr32/Kconfig
> ===================================================================
> --- linux-2.6.24-rc4.orig/arch/avr32/Kconfig
> +++ linux-2.6.24-rc4/arch/avr32/Kconfig
> @@ -66,6 +66,11 @@ config GENERIC_BUG
> def_bool y
> depends on BUG
>
> +config HAVE_KRETPROBES
> + bool
> + depends on HAVE_KPROBES
> + default n
> +

The symbol HAVE_KRETPROBES should be defined in the common file - so
the only thing you have to do is a single line:
config AVR32
+ select HAVE_KRETPROBES

Much more dense than defining the symbols once for each arch.

Sam