Re: [PATCH 1/4 -mm] kexec based hibernation -v7 : kexec jump

Huang, Ying
2007-12-11T00:57:18Z

On Mon, 2007-12-10 at 17:31 -0500, Vivek Goyal wrote:
> [..]
> >
> > -#define KEXEC_ON_CRASH 0x00000001
> > -#define KEXEC_ARCH_MASK 0xffff0000
> > +#define KEXEC_ON_CRASH 0x00000001
> > +#define KEXEC_PRESERVE_CPU 0x00000002
> > +#define KEXEC_PRESERVE_CPU_EXT 0x00000004
> > +#define KEXEC_SINGLE_CPU 0x00000008
> > +#define KEXEC_PRESERVE_DEVICE 0x00000010
> > +#define KEXEC_PRESERVE_CONSOLE 0x00000020
>
> Hi,
>
> Why do we need so many different flags for preserving different types
> of state (CPU, CPU_EXT, Device, console) ? To keep things simple,
> can't we can create just one flag KEXEC_PRESERVE_CONTEXT, which will
> indicate any special action required for preserving the previous kernel's
> context so that one can swith back to old kernel?

Yes. There are too many flags, especially when we have no users of these
flags now. It is better to use one flag such as KEXEC_PRESERVE_CONTEXT
now, and create the others required flags when really needed.

Best Regards,
Huang Ying