The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: linux-pcmcia@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Richard Knutsson <ricknu-0@student.ltu.se>
Subject: [PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning
Date: Tue, 11 Dec 2007 05:32:43 +0100 (MET)	[thread overview]
Message-ID: <20071211043417.28518.39249.sendpatchset@thinktank.campus.ltu.se> (raw)
In-Reply-To: <20071211043412.28518.40867.sendpatchset@thinktank.campus.ltu.se>

Fixing:
  CHECK   drivers/net/pcmcia/3c574_cs.c
drivers/net/pcmcia/3c574_cs.c:695:7: warning: symbol 'i' shadows an earlier one
drivers/net/pcmcia/3c574_cs.c:636:6: originally declared here

Signed-off-by: Richard Knutson <ricknu-0@student.ltu.se>
---


diff --git a/drivers/net/pcmcia/3c574_cs.c b/drivers/net/pcmcia/3c574_cs.c
index ad134a6..97b6daa 100644
--- a/drivers/net/pcmcia/3c574_cs.c
+++ b/drivers/net/pcmcia/3c574_cs.c
@@ -692,7 +692,7 @@ static void tc574_reset(struct net_device *dev)
 	mdio_write(ioaddr, lp->phys, 4, lp->advertising);
 	if (!auto_polarity) {
 		/* works for TDK 78Q2120 series MII's */
-		int i = mdio_read(ioaddr, lp->phys, 16) | 0x20;
+		i = mdio_read(ioaddr, lp->phys, 16) | 0x20;
 		mdio_write(ioaddr, lp->phys, 16, i);
 	}
 

  reply	other threads:[~2007-12-11  4:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11  4:32 [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning Richard Knutsson
2007-12-11  4:32 ` Richard Knutsson [this message]
2007-12-11 13:22   ` [PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning Alan Cox
2007-12-11  4:32 ` [PATCH 3/6] pcmcia/axnet_cs: Make functions static Richard Knutsson
2007-12-11  4:32 ` [PATCH 4/6] pcmcia/axnet_cs: Make use of 'max()' instead of handcrafted one Richard Knutsson
2007-12-11  4:32 ` [PATCH 5/6] pcmcia/fmvj18x_cs: Fix 'shadow variable' warning Richard Knutsson
2007-12-11  4:33 ` [PATCH 6/6] pcmcia/pcnet_cs: " Richard Knutsson
2007-12-11 13:19 ` [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning Alan Cox
2007-12-12  1:40   ` Richard Knutsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211043417.28518.39249.sendpatchset@thinktank.campus.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox