Re: [PATCH 2/2 V2] Kprobes: Build kretprobe examples only if arch supports kretprobes

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Ananth N Mavinakayanahalli (ananth@in.ibm.com) wrote:
> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> 
> This patch builds samples/kprobes/kretprobe_example.c only on archs that
> support kretprobes. Thanks to Sam Ravnborg for Kconfig suggestions.
> 
> V2: Updated dependency on CONFIG_KRETPROBES
> 
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

> ---
>  samples/Kconfig          |    5 +++++
>  samples/kprobes/Makefile |    4 ++--
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.24-rc4/samples/kprobes/Makefile
> ===================================================================
> --- linux-2.6.24-rc4.orig/samples/kprobes/Makefile
> +++ linux-2.6.24-rc4/samples/kprobes/Makefile
> @@ -1,5 +1,5 @@
>  # builds the kprobes example kernel modules;
>  # then to use one (as root):  insmod <module_name.ko>
>  
> -obj-$(CONFIG_SAMPLE_KPROBES) += kprobe_example.o jprobe_example.o \
> -		kretprobe_example.o
> +obj-$(CONFIG_SAMPLE_KPROBES) += kprobe_example.o jprobe_example.o
> +obj-$(CONFIG_SAMPLE_KRETPROBES) += kretprobe_example.o
> Index: linux-2.6.24-rc4/samples/Kconfig
> ===================================================================
> --- linux-2.6.24-rc4.orig/samples/Kconfig
> +++ linux-2.6.24-rc4/samples/Kconfig
> @@ -28,5 +28,10 @@ config SAMPLE_KPROBES
>  	help
>  	  This build several kprobes example modules.
>  
> +config SAMPLE_KRETPROBES
> +	tristate "Build kretprobes example -- loadable modules only"
> +	default m
> +	depends on SAMPLE_KPROBES && KRETPROBES
> +
>  endif # SAMPLES
>  

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68