Re: 2.6.24-rc3-git4 NFS crossmnt regression

Andrew Morton
2007-12-08T00:16:09Z

On Sat, 8 Dec 2007 03:00:43 +0300
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Sat, Dec 08, 2007 at 12:43:28AM +0100, Rafael J. Wysocki wrote:
> > On Saturday, 8 of December 2007, Andrew Morton wrote:
> > > On Fri, 07 Dec 2007 17:51:58 -0500
> > > Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > >
> > > >
> > > > On Fri, 2007-12-07 at 14:39 -0500, Shane wrote:
> > > > > On Dec 7, 2007 2:16 PM, Shane <gnome42@gmail.com> wrote:
> > > > > ...
> > > > > > Confirmed working in rc4-git5. I'll deploy this kernel in a few more
> > > > > > spots and check for other regressions.
> > > > >
> > > > > Hmm, I installed a new kernel built from the same sources on the NFS
> > > > > server. And now I don't see anything at all in the crossmnt dirs.
> > > > >
> > > > > ls /dirA/dirB/dirC --> zero output (empty dir)
> > > > >
> > > > > Are there any other pending fixes?
> > > > >
> > > > > Shane
> > > >
> > > > You've probably fallen afoul of
> > > >
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=9504
> > > >
> > >
> > > Yeah.
> > >
> > > I have a tentative fix below but I can't seem to get Eric and Denis to get
> > > a suitable fix nailed down. It's urgent!
> >
> > Well, how about asking Linus to revert commit
> > 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416 altogether and starting over again?
> >
> > It apparently causes more trouble than the issue it was supposed to fix.
>
> I very much agree. ->shadow_proc is so ugly, so it's not funny anymore.
> Adding such hook for proc part of networking _and_ for modules is just asking
> for trouble as was demonstrated.

OK, perhaps a revert is the best thing to do here. I don't think anyone
will be expecting fully finalised and robust netns support in 2.6.24.

Eric?