public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Unify mmap_{32|64}.c
Date: Tue, 11 Dec 2007 22:15:05 +0100	[thread overview]
Message-ID: <20071211211505.GC6902@elte.hu> (raw)
In-Reply-To: <1197400782.8761.10.camel@brick>


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Ingo,
> 
> Brown paper bag for me.
> 
> in mmap.c in mmap_is_ia32()
> 
> #ifdef X86_32
> 
> should of course be:
> 
> #ifdef CONFIG_X86_32
> 
> This would definitely explain the segfaults.  Do you want a 
> replacement patch or incremental?

no need, i'll fix it up.

	Ingo

      reply	other threads:[~2007-12-11 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1196889830.10408.50.camel@brick>
     [not found] ` <20071209081324.GB4509@elte.hu>
2007-12-10 15:50   ` [PATCH] x86: Unify mmap_{32|64}.c Harvey Harrison
2007-12-11  8:39     ` Ingo Molnar
2007-12-11 10:43       ` Ingo Molnar
2007-12-11 12:05         ` Jiri Kosina
2007-12-11 14:08           ` Ingo Molnar
2007-12-11 19:11             ` Harvey Harrison
2007-12-11 19:19             ` Harvey Harrison
2007-12-11 21:15               ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211211505.GC6902@elte.hu \
    --to=mingo@elte.hu \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox