From: Adrian Bunk <bunk@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] fs/nfs/direct.c: remove dead code
Date: Tue, 11 Dec 2007 23:21:11 +0100 [thread overview]
Message-ID: <20071211222111.GF14204@stusta.de> (raw)
This code became dead after commit b9148c6b80d802dbc2a7530b29915a80432e50c7
(which BTW doesn't seem to have changed any behaviour) and can therefore
be removed.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
--- linux-2.6/fs/nfs/direct.c.old 2007-12-02 21:54:53.000000000 +0100
+++ linux-2.6/fs/nfs/direct.c 2007-12-02 21:55:10.000000000 +0100
@@ -897,15 +897,12 @@ ssize_t nfs_file_direct_write(struct kio
if (!count)
goto out; /* return 0 */
retval = -EINVAL;
if ((ssize_t) count < 0)
goto out;
- retval = 0;
- if (!count)
- goto out;
retval = nfs_sync_mapping(mapping);
if (retval)
goto out;
retval = nfs_direct_write(iocb, iov, nr_segs, pos, count);
next reply other threads:[~2007-12-11 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 22:21 Adrian Bunk [this message]
2007-12-12 15:57 ` [2.6 patch] fs/nfs/direct.c: remove dead code Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211222111.GF14204@stusta.de \
--to=bunk@kernel.org \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox