Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

[Adrian Bunk <bunk@kernel.org>]

On Wed, Dec 12, 2007 at 09:44:10AM +1100, Michael Ellerman wrote:
> On Tue, 2007-12-11 at 23:19 +0100, Adrian Bunk wrote:
> > This patch fixes the following problem present with older gcc versions:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      drivers/pci/msi.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:692: warning: weak declaration of `arch_msi_check_device' after first use results in unspecified behavior
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:704: warning: weak declaration of `arch_setup_msi_irqs' after first use results in unspecified behavior
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/pci/msi.c:724: warning: weak declaration of `arch_teardown_msi_irqs' after first use results in unspecified behavior
> > ...
> > 
> > <--  snip  -->
> 
> They're declared in <linux/msi.h>, I don't see what it's problem is.

Older gcc versions don't like that they cannot see that they are weak 
functions at the time when they are used.

I'm not sure whether the generated code does the right thing, but even 
if it does rearranging the code doesn't do any harm here.

> cheers

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed