Re: [PATCH 46/47] Update and improve CRISv32 kernel/time.c

Andrew Morton
2007-12-12T11:33:47Z

On Tue, 4 Dec 2007 17:25:45 +0100 Jesper Nilsson <jesper.nilsson@axis.com> wrote:

> +#ifdef CONFIG_CPU_FREQ
> + cpufreq_register_notifier(&cris_time_freq_notifier_block,
> + CPUFREQ_TRANSITION_NOTIFIER);
> #endif

include/linux/cpufreq.h has

#ifdef CONFIG_CPU_FREQ
...
#else /* CONFIG_CPU_FREQ */
static inline int cpufreq_register_notifier(struct notifier_block *nb,
unsigned int list)
{
return 0;
}

the idea is that you remove the above ifdefs and also the ifdefs around
cris_time_freq_notifier_block and then gcc magically removes
cris_time_freq_notifier_block from your generated code.

Advantages: no ifdefs, and full typechecking even when CONFIG_CPU_FREQ=n.

cpufreq_register_notifier() can fail but this code pretends otherwise...