public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: akpm@linux-foundation.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@suse.de>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm -v2] x86 boot : export boot_params via sysfs
Date: Wed, 12 Dec 2007 09:46:13 -0800	[thread overview]
Message-ID: <20071212174613.GC16049@kroah.com> (raw)
In-Reply-To: <1197449991.14443.88.camel@caritas-dev.intel.com>

On Wed, Dec 12, 2007 at 04:59:51PM +0800, Huang, Ying wrote:
> This patch export the boot parameters via sysfs. This can be used for
> debugging and kexec.
> 
> The files added are as follow:
> 
> /sys/kernel/boot_params/data	: binary file for struct boot_params
> /sys/kernel/boot_params/version	: boot protocol version
> 
> This patch is based on 2.6.24-rc4-mm1 and has been tested on i386 and
> x86_64 platoform.
> 
> This patch is based on the Peter Anvin's proposal.

As outlined in a previous email, I object to the whole structure being
exported to userspace as a binary blob.  Please change that.

thanks,

greg k-h

  reply	other threads:[~2007-12-12 17:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12  8:59 [PATCH -mm -v2] x86 boot : export boot_params via sysfs Huang, Ying
2007-12-12 17:46 ` Greg KH [this message]
2007-12-12 17:54   ` H. Peter Anvin
2007-12-12 18:59     ` Greg KH
2007-12-12 19:05       ` H. Peter Anvin
2007-12-12 22:21         ` Greg KH
2007-12-12 22:37           ` H. Peter Anvin
2007-12-12 22:43           ` Randy Dunlap
2007-12-12 23:08             ` Eric W. Biederman
2007-12-12 22:52           ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071212174613.GC16049@kroah.com \
    --to=greg@kroah.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox