public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: akpm@linux-foundation.org
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, linux@bohmer.net,
	jonathan@jonmasters.org, matthias.kaehlcke@gmail.com,
	kjwinchester@gmail.com, mbuesch@freenet.de
Subject: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex
Date: Wed, 12 Dec 2007 00:00:03 -0800	[thread overview]
Message-ID: <20071213003032.547362071@mvista.com> (raw)
In-Reply-To: 20071213003023.117964080@mvista.com

[-- Attachment #1: bcm43xx-semaphore-to-mutex.patch --]
[-- Type: text/plain, Size: 4170 bytes --]


Signed-Off-By: Daniel Walker <dwalker@mvista.com>

---
 drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c |   30 ++++++++++++-------------
 1 file changed, 15 insertions(+), 15 deletions(-)

Index: linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
===================================================================
--- linux-2.6.23.orig/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
+++ linux-2.6.23/drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c
@@ -43,7 +43,7 @@
 
 static struct bcm43xx_debugfs fs;
 static char really_big_buffer[REALLY_BIG_BUFFER_SIZE];
-static DECLARE_MUTEX(big_buffer_sem);
+static DEFINE_MUTEX(big_buffer_mutex);
 
 
 static ssize_t write_file_dummy(struct file *file, const char __user *buf,
@@ -75,7 +75,7 @@ static ssize_t devinfo_read_file(struct 
 	u16 tmp16;
 	int i;
 
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 
 	mutex_lock(&bcm->mutex);
 	spin_lock_irqsave(&bcm->irq_lock, flags);
@@ -125,7 +125,7 @@ out:
 	spin_unlock_irqrestore(&bcm->irq_lock, flags);
 	mutex_unlock(&bcm->mutex);
 	res = simple_read_from_buffer(userbuf, count, ppos, buf, pos);
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -138,14 +138,14 @@ static ssize_t drvinfo_read_file(struct 
 	size_t pos = 0;
 	ssize_t res;
 
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 
 	/* This is where the information is written to the "driver" file */
 	fappend(KBUILD_MODNAME " driver\n");
 	fappend("Compiled at: %s %s\n", __DATE__, __TIME__);
 
 	res = simple_read_from_buffer(userbuf, count, ppos, buf, pos);
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -160,7 +160,7 @@ static ssize_t spromdump_read_file(struc
 	ssize_t res;
 	unsigned long flags;
 
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 	mutex_lock(&bcm->mutex);
 	spin_lock_irqsave(&bcm->irq_lock, flags);
 	if (bcm43xx_status(bcm) != BCM43xx_STAT_INITIALIZED) {
@@ -175,7 +175,7 @@ out:
 	spin_unlock_irqrestore(&bcm->irq_lock, flags);
 	mutex_unlock(&bcm->mutex);
 	res = simple_read_from_buffer(userbuf, count, ppos, buf, pos);
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -191,7 +191,7 @@ static ssize_t tsf_read_file(struct file
 	unsigned long flags;
 	u64 tsf;
 
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 	mutex_lock(&bcm->mutex);
 	spin_lock_irqsave(&bcm->irq_lock, flags);
 	if (bcm43xx_status(bcm) != BCM43xx_STAT_INITIALIZED) {
@@ -207,7 +207,7 @@ out:
 	spin_unlock_irqrestore(&bcm->irq_lock, flags);
 	mutex_unlock(&bcm->mutex);
 	res = simple_read_from_buffer(userbuf, count, ppos, buf, pos);
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -222,7 +222,7 @@ static ssize_t tsf_write_file(struct fil
 	unsigned long long tsf;
 
 	buf_size = min(count, sizeof (really_big_buffer) - 1);
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 	if (copy_from_user(buf, user_buf, buf_size)) {
 	        res = -EFAULT;
 		goto out_up;
@@ -247,7 +247,7 @@ out_unlock:
 	spin_unlock_irqrestore(&bcm->irq_lock, flags);
 	mutex_unlock(&bcm->mutex);
 out_up:
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -265,7 +265,7 @@ static ssize_t txstat_read_file(struct f
 	struct bcm43xx_xmitstatus *status;
 	int i, cnt, j = 0;
 
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 	mutex_lock(&bcm->mutex);
 	spin_lock_irqsave(&bcm->irq_lock, flags);
 
@@ -312,7 +312,7 @@ static ssize_t txstat_read_file(struct f
 	}
 	spin_unlock_irqrestore(&bcm->irq_lock, flags);
 	mutex_unlock(&bcm->mutex);
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 
@@ -326,7 +326,7 @@ static ssize_t restart_write_file(struct
 	unsigned long flags;
 
 	buf_size = min(count, sizeof (really_big_buffer) - 1);
-	down(&big_buffer_sem);
+	mutex_lock(&big_buffer_mutex);
 	if (copy_from_user(buf, user_buf, buf_size)) {
 	        res = -EFAULT;
 		goto out_up;
@@ -348,7 +348,7 @@ out_unlock:
 	spin_unlock_irqrestore(&(bcm)->irq_lock, flags);
 	mutex_unlock(&(bcm)->mutex);
 out_up:
-	up(&big_buffer_sem);
+	mutex_unlock(&big_buffer_mutex);
 	return res;
 }
 

-- 

  parent reply	other threads:[~2007-12-13  0:44 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071213003023.117964080@mvista.com>
2007-12-12  8:00 ` [PATCH 1/3] ps3: vuart: fix error path locking Daniel Walker
2007-12-13  2:00   ` Geoff Levand
2007-12-19  1:10     ` Andrew Morton
2007-12-19  1:54       ` Daniel Walker
2007-12-19  3:04       ` Geoff Levand
2007-12-20 19:32         ` Daniel Walker
2007-12-20 20:06           ` Andrew Morton
2007-12-20 20:13             ` Daniel Walker
2007-12-12  8:00 ` [PATCH 2/3] driver base: memory: semaphore to mutex Daniel Walker
2007-12-12  8:00 ` Daniel Walker [this message]
2007-12-13  0:48   ` [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem " Michael Buesch
2007-12-13  1:17     ` Ray Lee
2007-12-13 13:45       ` Michael Buesch
2007-12-14  0:05         ` Ray Lee
2007-12-14  0:43           ` Michael Buesch
2007-12-14  0:55             ` Harvey Harrison
2007-12-14 10:45               ` Michael Buesch
2007-12-14  1:12             ` Ray Lee
2007-12-14 10:49               ` Michael Buesch
2007-12-14 11:15                 ` Ingo Molnar
2007-12-14 11:39                   ` Michael Buesch
2007-12-14 12:16                     ` Ingo Molnar
2007-12-14 12:31                       ` Michael Buesch
2007-12-14 12:53                         ` Ingo Molnar
2007-12-14 13:08                           ` Michael Buesch
2007-12-14 16:06                             ` Ray Lee
2007-12-14 16:49                               ` Michael Buesch
2007-12-14 18:01                                 ` Ray Lee
2007-12-14 18:11                                   ` Ingo Molnar
2007-12-14 18:47                                     ` Ray Lee
2007-12-14 18:22                                   ` Michael Buesch
2007-12-14 18:45                                     ` Ray Lee
2007-12-14 19:05                                       ` Michael Buesch
2007-12-14 19:25                                         ` Ray Lee
2007-12-14 19:38                                           ` Michael Buesch
2007-12-14 19:55                                             ` Ray Lee
2007-12-14 20:13                                               ` Michael Buesch
2007-12-14 21:39                                                 ` Ray Lee
2007-12-14 12:59                         ` Simon Holm Thøgersen
2007-12-14 13:04                           ` Michael Buesch
2007-12-15  0:51                             ` Rafael J. Wysocki
2007-12-15  0:58                               ` Larry Finger
2007-12-15  1:59                                 ` mvtodevnull
2007-12-15  2:27                                   ` Larry Finger
2007-12-15  4:37                                     ` mvtodevnull
2007-12-15  4:39                                       ` mvtodevnull
2007-12-15  7:18                                         ` Larry Finger
2007-12-15 12:38                                           ` mvtodevnull
2007-12-17  2:17                                             ` mvtodevnull
2007-12-17  6:52                                               ` Larry Finger
2007-12-17  7:17                                                 ` mvtodevnull
2007-12-17  9:49                                                   ` Michael Buesch
2007-12-17 10:15                                                     ` mvtodevnull
2007-12-17 10:35                                                       ` mvtodevnull
2007-12-17 22:04                                                         ` mvtodevnull
2007-12-17 22:45                                                           ` Michael Buesch
2007-12-17 23:12                                                             ` mvtodevnull
2007-12-17 23:18                                                               ` Michael Buesch
2007-12-17 23:27                                                                 ` mvtodevnull
2007-12-18  1:16                                                   ` Larry Finger
2007-12-18  2:34                                                     ` mvtodevnull
2007-12-19  2:12                                                       ` mvtodevnull
2007-12-19  8:11                                                         ` Larry Finger
     [not found]                                                           ` <200712191046.54147.mb@bu3sch.de>
2007-12-19 13:48                                                             ` Ingo Molnar
2007-12-15 10:57                               ` Michael Buesch
2007-12-15 23:18                                 ` Rafael J. Wysocki
2007-12-15 23:27                                   ` Michael Buesch
2007-12-16  2:30                                     ` Larry Finger
2007-12-16 11:13                                       ` Michael Buesch
2007-12-16 13:56                                     ` Johannes Berg
2007-12-16 14:35                                       ` Rafael J. Wysocki
2007-12-16 14:18                                         ` Johannes Berg
2007-12-14  2:09             ` Larry Finger
2007-12-14 10:56             ` Ingo Molnar
2007-12-14 14:14               ` John W. Linville
2007-12-14 14:40                 ` stefano.brivio
2007-12-14 16:27                   ` Ray Lee
2007-12-14 16:45                     ` Ray Lee
2007-12-14 16:59                       ` Michael Buesch
2007-12-14 17:22                         ` Ray Lee
2007-12-14 17:59                         ` Ingo Molnar
2007-12-14 18:38                           ` Michael Buesch
2007-12-15  1:25                             ` Rafael J. Wysocki
2007-12-15 21:43                               ` John W. Linville
2007-12-15 23:26                                 ` Rafael J. Wysocki
2007-12-16  3:20                                   ` Stefan Lippers-Hollmann
2007-12-16  9:22                                 ` Ingo Molnar
2007-12-16 11:23                                   ` Michael Buesch
2007-12-13  1:20     ` Daniel Walker
2007-12-13 10:13       ` Ingo Molnar
2007-12-13 11:11         ` Michael Buesch
2007-12-13 14:23           ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071213003032.547362071@mvista.com \
    --to=dwalker@mvista.com \
    --cc=akpm@linux-foundation.org \
    --cc=jonathan@jonmasters.org \
    --cc=kjwinchester@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@bohmer.net \
    --cc=matthias.kaehlcke@gmail.com \
    --cc=mbuesch@freenet.de \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox