public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: Next patches for the 2.6.25 queue
Date: Thu, 13 Dec 2007 16:49:09 +0100	[thread overview]
Message-ID: <20071213154908.GH10069@stusta.de> (raw)
In-Reply-To: <20071213144642.GA7800@Krystal>

On Thu, Dec 13, 2007 at 09:46:42AM -0500, Mathieu Desnoyers wrote:
> Hi Andrew,
> 
> I would like to post my next patches in a way that would make it as
> easy for you and the community to review them. Currently, the patches
> that have really settled down are :
> 
> * For 2.6.25
>...
> - Immediate Values
>   - Redux version, asked by Rusty
>...

I might have missed it:

Are there any real numbers (opposed to estimates and microbenchmarks) 
available how much performance we actually gain in which situations?

It might be some workload with markers using Immediate Values or 
something like that, but it should be something where the kernel
runs measurably faster with Immediate Values than without.

Currently I'm somewhere between "your Immediate Values are just an 
academic code obfuscation without any gain in practice" and "janitors 
should convert all drivers to use Immediate Values", and I'd like to 
form an opinion based on in which situations the kernel runs faster by 
how many percent.

That's also based on observation like e.g. that __read_mostly should 
improve the performance, but I've already seen situations in the kernel 
where it forced gcc to emit code that was obviously both bigger and 
slower than without the __read_mostly [1], and that's part of why I'm 
sceptical of all optimizations below the C level unless proven 
otherwise.

> Thanks,
> 
> Mathieu

cu
Adrian

[1] Figuring out what might have happened is left as an exercise to the 
    reader.  :-)

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-12-13 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13 14:46 Next patches for the 2.6.25 queue Mathieu Desnoyers
2007-12-13 15:49 ` Adrian Bunk [this message]
2007-12-14 16:43   ` Mathieu Desnoyers
2007-12-15 22:14     ` Adrian Bunk
2007-12-13 21:32 ` Andrew Morton
2007-12-13 22:18   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071213154908.GH10069@stusta.de \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox