From: Dave Jones <davej@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
venkatesh.pallipadi@intel.com
Subject: Re: [crash] kernel BUG at drivers/cpufreq/cpufreq.c:1060!
Date: Thu, 13 Dec 2007 12:50:38 -0500 [thread overview]
Message-ID: <20071213175038.GD28148@redhat.com> (raw)
In-Reply-To: <20071213101711.GN8977@elte.hu>
On Thu, Dec 13, 2007 at 11:17:11AM +0100, Ingo Molnar wrote:
>
> * Dave Jones <davej@redhat.com> wrote:
>
> > > It _looks_ like we're leaking a refcount on that lock, but I don't
> > > see where. It's a shame you can't reproduce this easily, as
> > > cpufreq.debug=7 would give us more clues. (And
> > > CONFIG_CPUFREQ_DEBUG=y)
> >
> > So we're missing some unlocks in some error paths. It's feasible you
> > hit one of those. This patch should be the fix for that.
>
> since it's not really reproducible (i failed to get it since then), how
> about you push your fix upstream (it's an obviously correct fix), we
> consider this regression fixed and i'll re-notify you if there's still
> any problem left. It's not like there's any escape from make randconfig
> bootup test coverage in the long run ;-)
Yeah, will push it to Linus today.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2007-12-13 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 9:11 [crash] kernel BUG at drivers/cpufreq/cpufreq.c:1060! Ingo Molnar
2007-12-12 9:57 ` Ingo Molnar
2007-12-12 10:21 ` Alexey Dobriyan
2007-12-12 10:35 ` Ingo Molnar
2007-12-12 16:40 ` Dave Jones
2007-12-12 18:18 ` Dave Jones
2007-12-13 10:17 ` Ingo Molnar
2007-12-13 17:50 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213175038.GD28148@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox