Re: Print taint info in more places.

Dave Jones
2007-12-13T23:52:57Z

On Fri, Dec 14, 2007 at 12:08:46AM +0100, Andi Kleen wrote:
> Dave Jones <davej@redhat.com> writes:
>
> > #define WARN_ON(condition) ({ \
> > int __ret_warn_on = !!(condition); \
> > if (unlikely(__ret_warn_on)) { \
> > - printk("WARNING: at %s:%d %s()\n", __FILE__, \
> > - __LINE__, __FUNCTION__); \
> > + printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n", \
> > + __FILE__, __LINE__, __FUNCTION__, \
> > + print_tainted()); \
> > dump_stack(); \
>
> Have you checked how this affects code size? It might be worth it
> now to do a out of line helper.

64 bit debug build of the fedora kernel (which should be worse
case for WARN_ONs etc).

text data bss dec hex filename
before 3833875 834267 631136 5299278 50dc4e vmlinux
after 3837054 834267 631136 5302457 50e8b9 vmlinux

Some of that growth is the addition of the missing KERN_ERR,
but yeah, it grows a little bit.

Dave