From: Dave Jones <davej@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Print taint info in more places.
Date: Thu, 13 Dec 2007 18:52:42 -0500 [thread overview]
Message-ID: <20071213235242.GA12755@redhat.com> (raw)
In-Reply-To: <p73y7byfb0h.fsf@bingen.suse.de>
On Fri, Dec 14, 2007 at 12:08:46AM +0100, Andi Kleen wrote:
> Dave Jones <davej@redhat.com> writes:
>
> > #define WARN_ON(condition) ({ \
> > int __ret_warn_on = !!(condition); \
> > if (unlikely(__ret_warn_on)) { \
> > - printk("WARNING: at %s:%d %s()\n", __FILE__, \
> > - __LINE__, __FUNCTION__); \
> > + printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n", \
> > + __FILE__, __LINE__, __FUNCTION__, \
> > + print_tainted()); \
> > dump_stack(); \
>
> Have you checked how this affects code size? It might be worth it
> now to do a out of line helper.
64 bit debug build of the fedora kernel (which should be worse
case for WARN_ONs etc).
text data bss dec hex filename
before 3833875 834267 631136 5299278 50dc4e vmlinux
after 3837054 834267 631136 5302457 50e8b9 vmlinux
Some of that growth is the addition of the missing KERN_ERR,
but yeah, it grows a little bit.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-12-13 23:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 22:49 Print taint info in more places Dave Jones
2007-12-13 23:08 ` Andi Kleen
2007-12-13 23:43 ` Mauricio Mauad Menegaz Filho
2007-12-13 23:52 ` Dave Jones [this message]
2007-12-14 0:12 ` Dave Jones
2007-12-14 0:03 ` Adrian Bunk
2007-12-14 0:16 ` Dave Jones
2007-12-14 1:30 ` Dave Jones
2007-12-14 7:25 ` Jeremy Fitzhardinge
2007-12-14 7:55 ` Dave Jones
2007-12-14 15:38 ` Matt Mackall
2007-12-14 16:56 ` Dave Jones
2007-12-14 12:09 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213235242.GA12755@redhat.com \
--to=davej@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox