From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765787AbXLMXw5 (ORCPT ); Thu, 13 Dec 2007 18:52:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758113AbXLMXwr (ORCPT ); Thu, 13 Dec 2007 18:52:47 -0500 Received: from mx1.redhat.com ([66.187.233.31]:55826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756194AbXLMXwq (ORCPT ); Thu, 13 Dec 2007 18:52:46 -0500 Date: Thu, 13 Dec 2007 18:52:42 -0500 From: Dave Jones To: Andi Kleen Cc: Linux Kernel Subject: Re: Print taint info in more places. Message-ID: <20071213235242.GA12755@redhat.com> Mail-Followup-To: Dave Jones , Andi Kleen , Linux Kernel References: <20071213224927.GA18639@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2007 at 12:08:46AM +0100, Andi Kleen wrote: > Dave Jones writes: > > > #define WARN_ON(condition) ({ \ > > int __ret_warn_on = !!(condition); \ > > if (unlikely(__ret_warn_on)) { \ > > - printk("WARNING: at %s:%d %s()\n", __FILE__, \ > > - __LINE__, __FUNCTION__); \ > > + printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n", \ > > + __FILE__, __LINE__, __FUNCTION__, \ > > + print_tainted()); \ > > dump_stack(); \ > > Have you checked how this affects code size? It might be worth it > now to do a out of line helper. 64 bit debug build of the fedora kernel (which should be worse case for WARN_ONs etc). text data bss dec hex filename before 3833875 834267 631136 5299278 50dc4e vmlinux after 3837054 834267 631136 5302457 50e8b9 vmlinux Some of that growth is the addition of the missing KERN_ERR, but yeah, it grows a little bit. Dave -- http://www.codemonkey.org.uk