From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932477AbXLNCPH (ORCPT ); Thu, 13 Dec 2007 21:15:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757746AbXLNCOy (ORCPT ); Thu, 13 Dec 2007 21:14:54 -0500 Received: from e28smtp06.in.ibm.com ([59.145.155.6]:46390 "EHLO e28esmtp06.in.ibm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757137AbXLNCOy (ORCPT ); Thu, 13 Dec 2007 21:14:54 -0500 Date: Fri, 14 Dec 2007 07:44:33 +0530 From: Dhaval Giani To: Ingo Molnar Cc: Kay Sievers , vincent.fortier1@ec.gc.ca, Greg KH , Randy Dunlap , Andrew Morton , linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Balbir Singh , maneesh@in.ibm.com Subject: Re: 2.6.22.14 oops msg with commvault galaxy ? Message-ID: <20071214021433.GA7185@linux.vnet.ibm.com> Reply-To: Dhaval Giani References: <1197554397.19869.3.camel@lov.site> <1197558120.4936.34.camel@kayak.wul.qc.ec.gc.ca> <1197562981.19869.5.camel@lov.site> <20071213165059.GC4865@elte.hu> <1197565842.19869.11.camel@lov.site> <20071213202125.GA25130@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071213202125.GA25130@elte.hu> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2007 at 09:21:26PM +0100, Ingo Molnar wrote: > > * Kay Sievers wrote: > > > > > > This one also fails to apply properly at the exact same place > > > > > has Ingo's previously posted patch. Would need to backport his > > > > > one. > > > > > > > > It depends on a completely reworked sysfs logic, I don't think it > > > > makes any sense to backport that. > > > > > > well, if it fixes a live bug in a still supported stable kernel > > > release... > > > > > > Vincent, could you try to just get rid of all actual uses of > > > se->attr.owner, within fs/sysfs/*.c? Something like the patch below. > > > (totally untested - might be fatally broken as well) > > > > How can you think that this is not needed? You can not remove it with > > sysfs you are patching. Hope this explains it: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0ab66088c855eca68513bdd7442a426c4b374ced > > yeah - as i said it might be fatally broken (in fact it is). Do we > understand why Vincent got the crashes with vanilla 2.6.22.14 ? > My guess is some variables have probably been left uninitialized. I am a bit too scared to look into sysfs parts of the code now. -- regards, Dhaval