From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] UML - Add asm/fixmap.h include
Date: Fri, 14 Dec 2007 09:58:40 -0800 [thread overview]
Message-ID: <20071214095840.28736204.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071214161647.GA5802@c2.user-mode-linux.org>
On Fri, 14 Dec 2007 11:16:47 -0500 Jeff Dike <jdike@addtoit.com> wrote:
> [ This needs to go into 2.6.24, as it fixes a build breakage seen on x86_64 ]
>
> um_uaccess.h refers to FIXADDR_USER_*, so it should include fixmap.h.
>
> I also changed the non-UML includes to use <> instead of "".
>
> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
> ---
> arch/um/include/um_uaccess.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.22/arch/um/include/um_uaccess.h
> ===================================================================
> --- linux-2.6.22.orig/arch/um/include/um_uaccess.h 2007-12-13 10:09:22.000000000 -0500
> +++ linux-2.6.22/arch/um/include/um_uaccess.h 2007-12-13 15:11:42.000000000 -0500
> @@ -6,7 +6,8 @@
> #ifndef __ARCH_UM_UACCESS_H
> #define __ARCH_UM_UACCESS_H
>
> -#include "asm/elf.h"
> +#include <asm/elf.h>
> +#include <asm/fixmap.h>
> #include "sysdep/archsetjmp.h"
>
> #define __under_task_size(addr, size) \
arch/um/include/um_uaccess.h already includes fixmap.h. Is this a -mm-only
fix?
next prev parent reply other threads:[~2007-12-14 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 16:16 [PATCH] UML - Add asm/fixmap.h include Jeff Dike
2007-12-14 17:58 ` Andrew Morton [this message]
2007-12-14 18:55 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214095840.28736204.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox