From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759668AbXLNR3Z (ORCPT ); Fri, 14 Dec 2007 12:29:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750794AbXLNR3Q (ORCPT ); Fri, 14 Dec 2007 12:29:16 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47851 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbXLNR3Q (ORCPT ); Fri, 14 Dec 2007 12:29:16 -0500 Date: Fri, 14 Dec 2007 09:28:14 -0800 From: Greg KH To: Dhaval Giani Cc: Ingo Molnar , Kay Sievers , vincent.fortier1@ec.gc.ca, Randy Dunlap , Andrew Morton , linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Balbir Singh , maneesh@in.ibm.com Subject: Re: 2.6.22.14 oops msg with commvault galaxy ? Message-ID: <20071214172814.GA14597@suse.de> References: <1197554397.19869.3.camel@lov.site> <1197558120.4936.34.camel@kayak.wul.qc.ec.gc.ca> <1197562981.19869.5.camel@lov.site> <20071213165059.GC4865@elte.hu> <1197565842.19869.11.camel@lov.site> <20071213202125.GA25130@elte.hu> <20071214162642.GA13898@suse.de> <20071214170739.GA2576@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071214170739.GA2576@linux.vnet.ibm.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2007 at 10:37:39PM +0530, Dhaval Giani wrote: > On Fri, Dec 14, 2007 at 08:26:42AM -0800, Greg KH wrote: > > On Thu, Dec 13, 2007 at 09:21:26PM +0100, Ingo Molnar wrote: > > > > > > * Kay Sievers wrote: > > > > > > > > > > This one also fails to apply properly at the exact same place > > > > > > > has Ingo's previously posted patch. Would need to backport his > > > > > > > one. > > > > > > > > > > > > It depends on a completely reworked sysfs logic, I don't think it > > > > > > makes any sense to backport that. > > > > > > > > > > well, if it fixes a live bug in a still supported stable kernel > > > > > release... > > > > > > > > > > Vincent, could you try to just get rid of all actual uses of > > > > > se->attr.owner, within fs/sysfs/*.c? Something like the patch below. > > > > > (totally untested - might be fatally broken as well) > > > > > > > > How can you think that this is not needed? You can not remove it with > > > > sysfs you are patching. Hope this explains it: > > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0ab66088c855eca68513bdd7442a426c4b374ced > > > > > > yeah - as i said it might be fatally broken (in fact it is). Do we > > > understand why Vincent got the crashes with vanilla 2.6.22.14 ? > > > > No, and I can't seem to duplicate them here at all. > > > > Does anyone have a test case for this that I can work on trying to > > duplicate? > > > > If you apply CFS without my fix, and try to constantly check cpu_shares > for a user who is logging and logging out, you should hit it. (That's > what I was doing). Hm, how about a "vanilla 2.6.22.14 kernel _without_ any patches". That's what I am most worried about :) thanks, greg k-h