From: Dave Jones <davej@redhat.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off
Date: Sat, 15 Dec 2007 01:45:55 -0500 [thread overview]
Message-ID: <20071215064555.GA7211@redhat.com> (raw)
In-Reply-To: <20071215055218.GM19691@waste.org>
On Fri, Dec 14, 2007 at 11:52:18PM -0600, Matt Mackall wrote:
> Then I kindly submit that you should instead withdraw the code that
> allows you to use WARN_ON in a condition in the first place.
>
> Note that Dave Jones is currently poking at making WARN_ON
> out-of-line, so you're liable to collide with him.
Actually I'm not likely to get back to this until post xmas.
I'm on vacation until then from today, so I'll be paying less
attention to stuff than usual.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-12-15 6:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 13:27 [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off Herbert Xu
2007-12-14 18:02 ` Matt Mackall
2007-12-15 4:16 ` Herbert Xu
2007-12-15 5:52 ` Matt Mackall
2007-12-15 6:04 ` Herbert Xu
2007-12-15 6:12 ` Matt Mackall
2007-12-15 6:31 ` Herbert Xu
2007-12-15 6:52 ` Herbert Xu
2007-12-15 17:54 ` Matt Mackall
2007-12-15 6:45 ` Dave Jones [this message]
2007-12-15 6:22 ` Benjamin Herrenschmidt
2007-12-15 6:31 ` Benjamin Herrenschmidt
2007-12-15 6:34 ` Herbert Xu
2007-12-15 18:12 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071215064555.GA7211@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox