From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: FInal kprobes rollup patches
Date: Sat, 15 Dec 2007 09:50:15 +0100 [thread overview]
Message-ID: <20071215085015.GA9720@elte.hu> (raw)
In-Reply-To: <1197708350.898.87.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Further unification work. There is a possible behavior change on
> X86_32 here.
>
> is_IF_modifier(p->opcode)
>
> to
>
> is_IF_modifier(p->ainsn.insn)
>
> Which should be equivalent, but is not purely cosmetic as the rest of
> the unification so far.
hm, could you split this into two, the pure-equivalence and the
possibly-modifying patch? (that way any potential breakage becomes
bisectable) Same end result, just two commits instead of one.
also, did you manage to run/test kprobes (on 32-bit or 64-bit x86), and
it worked fine?
Ingo
next prev parent reply other threads:[~2007-12-15 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 8:45 FInal kprobes rollup patches Harvey Harrison
2007-12-15 8:50 ` Ingo Molnar [this message]
2007-12-15 9:04 ` Harvey Harrison
2007-12-15 13:12 ` Ingo Molnar
2007-12-17 14:12 ` Srikar Dronamraju
2007-12-17 14:13 ` Masami Hiramatsu
2007-12-17 14:30 ` Final " Ingo Molnar
2007-12-17 15:29 ` Masami Hiramatsu
2007-12-17 16:06 ` Ingo Molnar
2007-12-17 16:19 ` Masami Hiramatsu
2007-12-17 20:17 ` Harvey Harrison
2007-12-17 14:22 ` FInal " Srikar Dronamraju
2007-12-17 19:20 ` Harvey Harrison
2007-12-17 21:28 ` Masami Hiramatsu
2007-12-17 21:36 ` Harvey Harrison
2007-12-17 21:52 ` Masami Hiramatsu
2007-12-17 22:00 ` Harvey Harrison
2007-12-17 23:14 ` Masami Hiramatsu
2007-12-17 23:27 ` Harvey Harrison
2007-12-17 23:56 ` Masami Hiramatsu
2007-12-18 0:27 ` Masami Hiramatsu
2007-12-18 2:15 ` Harvey Harrison
2007-12-18 3:10 ` [PATCH] x86: kprobes use stack_addr() macro Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071215085015.GA9720@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox