From: Andi Kleen <andi@firstfloor.org>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Eduard-Gabriel Munteanu <eduard.munteanu@linux360.ro>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)
Date: Sat, 15 Dec 2007 13:41:47 +0100 [thread overview]
Message-ID: <20071215124147.GA26909@one.firstfloor.org> (raw)
In-Reply-To: <47630521.4060505@redhat.com>
On Fri, Dec 14, 2007 at 05:35:13PM -0500, Chuck Ebbert wrote:
> On 12/14/2007 05:17 AM, Andi Kleen wrote:
> >> so do whatever is necessary to enable dynticks.
> >
> > dynticks' main purpose is to save power, but C1e saves more power.
> > Disabling C1e for dynticks would be a fairly useless default
> > trade off.
> >
>
> What about machines where the BIOS has disabled C1e on CPU 0 but
> left it enabled on CPU 1 ??
It's a BIOS bug. We handle this and threat it like C1e always enabled.
The right fix would be to enable it on both CPUs, but
then that's not strictly needed for correct operation and I'm not
sure it would be worth special fixup code in Linux. Probably not.
-Andi
next prev parent reply other threads:[~2007-12-15 12:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 22:44 [PATCH] Option to disable AMD C1E (allows dynticks to work) Eduard-Gabriel Munteanu
2007-12-13 22:33 ` Andi Kleen
2007-12-14 12:39 ` Eduard-Gabriel Munteanu
2007-12-14 10:17 ` Andi Kleen
2007-12-14 13:41 ` Eduard-Gabriel Munteanu
2007-12-14 12:20 ` Andi Kleen
2007-12-14 16:01 ` Eduard-Gabriel Munteanu
2007-12-14 18:07 ` Thomas Gleixner
2007-12-14 18:12 ` Andi Kleen
2007-12-14 19:57 ` Thomas Gleixner
2007-12-14 20:06 ` Andi Kleen
2007-12-14 19:58 ` Eduard-Gabriel Munteanu
2007-12-14 18:10 ` Andi Kleen
2007-12-14 19:53 ` Thomas Gleixner
2007-12-14 22:35 ` Chuck Ebbert
2007-12-15 0:10 ` Eduard-Gabriel Munteanu
2007-12-15 12:41 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-13 22:47 Eduard-Gabriel Munteanu
2007-12-13 22:58 ` Johannes Weiner
2007-12-14 12:48 ` Eduard-Gabriel Munteanu
2007-12-18 15:43 ` Pavel Machek
2007-12-18 17:11 ` Eduard-Gabriel Munteanu
2007-12-14 0:14 Mikhail Kshevetskiy
[not found] <47754735.1050009@richardharman.com>
2007-12-29 7:52 ` Eduard-Gabriel Munteanu
2007-12-29 9:09 ` Richard Harman
2007-12-29 11:19 ` Eduard-Gabriel Munteanu
2007-12-29 11:46 ` Islam Amer
2007-12-30 20:45 ` Rene Herman
2007-12-29 14:43 David P. Reed
2007-12-29 22:28 ` Islam Amer
2007-12-30 0:35 ` Islam Amer
2007-12-30 12:57 ` Ingo Molnar
2007-12-30 1:38 ` Rene Herman
2007-12-30 1:49 ` Islam Amer
2007-12-30 3:24 ` Rene Herman
2007-12-30 10:17 ` Eduard-Gabriel Munteanu
2007-12-30 14:42 ` Andi Kleen
2007-12-30 21:12 ` Eduard-Gabriel Munteanu
2007-12-31 2:34 ` Andi Kleen
2007-12-30 20:57 ` Richard Harman
2007-12-30 21:18 ` Eduard-Gabriel Munteanu
2007-12-30 13:36 ` Richard Harman
2007-12-30 23:32 ` Eduard-Gabriel Munteanu
2007-12-31 0:30 ` David P. Reed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071215124147.GA26909@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=cebbert@redhat.com \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox