* [PATCH] alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value.
@ 2007-12-16 0:36 Miguel Botón
2007-12-17 8:07 ` Jaroslav Kysela
0 siblings, 1 reply; 2+ messages in thread
From: Miguel Botón @ 2007-12-16 0:36 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: perex
"[ALSA] Use posix clock monotonic for PCM and timer timestamps" introduces
a bug that makes audio device unusable in some computers.
Signed-off-by: Miguel Botón <mboton@gmail.com>
diff --git a/include/sound/asound.h b/include/sound/asound.h
index 475eb71..d35aa44 100644
--- a/include/sound/asound.h
+++ b/include/sound/asound.h
@@ -443,7 +443,7 @@ enum {
enum {
SNDRV_PCM_IOCTL_PVERSION = _IOR('A', 0x00, int),
SNDRV_PCM_IOCTL_INFO = _IOR('A', 0x01, struct snd_pcm_info),
- SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x03, int),
+ SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x02, int),
SNDRV_PCM_IOCTL_HW_REFINE = _IOWR('A', 0x10, struct snd_pcm_hw_params),
SNDRV_PCM_IOCTL_HW_PARAMS = _IOWR('A', 0x11, struct snd_pcm_hw_params),
SNDRV_PCM_IOCTL_HW_FREE = _IO('A', 0x12),
--
Miguel Botón
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value.
2007-12-16 0:36 [PATCH] alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value Miguel Botón
@ 2007-12-17 8:07 ` Jaroslav Kysela
0 siblings, 0 replies; 2+ messages in thread
From: Jaroslav Kysela @ 2007-12-17 8:07 UTC (permalink / raw)
To: Miguel Botón; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1184 bytes --]
On Sun, 16 Dec 2007, Miguel Botón wrote:
> "[ALSA] Use posix clock monotonic for PCM and timer timestamps" introduces
> a bug that makes audio device unusable in some computers.
>
> Signed-off-by: Miguel Botón <mboton@gmail.com>
Thanks for notify that old alsa-lib binaries have trouble with this patch.
But your fix is wrong. New and old ioctls are incompatible. I added old
ioctl back to our HG tree.
Jaroslav
> diff --git a/include/sound/asound.h b/include/sound/asound.h
> index 475eb71..d35aa44 100644
> --- a/include/sound/asound.h
> +++ b/include/sound/asound.h
> @@ -443,7 +443,7 @@ enum {
> enum {
> SNDRV_PCM_IOCTL_PVERSION = _IOR('A', 0x00, int),
> SNDRV_PCM_IOCTL_INFO = _IOR('A', 0x01, struct snd_pcm_info),
> - SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x03, int),
> + SNDRV_PCM_IOCTL_TTSTAMP = _IOW('A', 0x02, int),
> SNDRV_PCM_IOCTL_HW_REFINE = _IOWR('A', 0x10, struct snd_pcm_hw_params),
> SNDRV_PCM_IOCTL_HW_PARAMS = _IOWR('A', 0x11, struct snd_pcm_hw_params),
> SNDRV_PCM_IOCTL_HW_FREE = _IO('A', 0x12),
>
> --
> Miguel Botón
>
-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-17 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-16 0:36 [PATCH] alsa: fix SNDRV_PCM_IOCTL_TTSTAMP value Miguel Botón
2007-12-17 8:07 ` Jaroslav Kysela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox