Re: [PATCH 5/6] udf: fix signedness issue

Jan Kara
2007-12-17T16:32:28Z

> sparse generated:
> fs/udf/namei.c:896:15: originally declared here
> fs/udf/namei.c:1147:41: warning: incorrect type in argument 3 (different signedness)
> fs/udf/namei.c:1147:41: expected int *offset
> fs/udf/namei.c:1147:41: got unsigned int *<noident>
> fs/udf/namei.c:1152:78: warning: incorrect type in argument 3 (different signedness)
> fs/udf/namei.c:1152:78: expected int *offset
> fs/udf/namei.c:1152:78: got unsigned int *<noident>
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
I don't think this is right. udf_get_fileident() should take "unsigned
int *" as an offset, not just "int". This means changing struct
udf_fileident_bh to use unsigned int too but that is better anyway.
And BTW the type shouldn't be uint32_t but really unsigned int in
udf_rename (int needn't have 32 bits on all archs (although I think it
has currently)).

Honza

> ---
> fs/udf/namei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index bec96a6..066153f 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -1131,7 +1131,7 @@ static int udf_rename(struct inode *old_dir, struct dentry *old_dentry,
> }
> }
> if (S_ISDIR(old_inode->i_mode)) {
> - uint32_t offset = udf_ext0_offset(old_inode);
> + int offset = udf_ext0_offset(old_inode);
>
> if (new_inode) {
> retval = -ENOTEMPTY;
> --
> 1.5.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@suse.cz>
SuSE CR Labs