Re: div64: Rework 64-bit type safety checks in do_div().

Al Viro
2007-12-17T05:05:29Z

On Mon, Dec 17, 2007 at 12:20:19PM +0900, Paul Mundt wrote:
> (Adding Ingo to CC regarding kernel/lockdep_proc.c..)

> That seems to be an accurate asessment, yes. If do_div(s64, ...) is buggy
> behaviour, then the current check is fine, and the callsites should be
> corrected. Though if there's code in-tree that relies on s64 do_div, that seems
> to be a more problematic issue.

It is a bug and the only existing callers that manage to work are those that
make sure that signed value is positive. Still asking for trouble...