From: Roman Zippel <zippel@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] initrd: Fix virtual/physical mix-up in overwrite test
Date: Mon, 17 Dec 2007 05:14:18 +0100 [thread overview]
Message-ID: <200712170514.20465.zippel@linux-m68k.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712161148340.5869@anakin>
Hi,
On Sunday 16 December 2007, Geert Uytterhoeven wrote:
> --- a/init/main.c
> +++ b/init/main.c
> @@ -598,9 +598,9 @@ asmlinkage void __init start_kernel(void
>
> #ifdef CONFIG_BLK_DEV_INITRD
> if (initrd_start && !initrd_below_start_ok &&
> - initrd_start < min_low_pfn << PAGE_SHIFT) {
> + virt_to_pfn(initrd_start) < min_low_pfn) {
> printk(KERN_CRIT "initrd overwritten (0x%08lx < 0x%08lx) - "
> - "disabling it.\n",initrd_start,min_low_pfn << PAGE_SHIFT);
> + "disabling it.\n", virt_to_pfn(initrd_start), min_low_pfn);
> initrd_start = 0;
> }
> #endif
BTW this is some really old code, so another option might be to remove this
check completely as the same check is already done via bootmem.
bye, Roman
next prev parent reply other threads:[~2007-12-17 4:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 10:51 [PATCH] initrd: Fix virtual/physical mix-up in overwrite test Geert Uytterhoeven
2007-12-17 4:14 ` Roman Zippel [this message]
2007-12-18 11:01 ` Andrew Morton
2007-12-18 19:52 ` Geert Uytterhoeven
2007-12-18 20:31 ` Andrew Morton
2007-12-23 10:43 ` Geert Uytterhoeven
2008-06-15 14:07 ` Geert Uytterhoeven
2008-06-16 1:11 ` Andrew Morton
2008-06-16 6:20 ` Geert Uytterhoeven
2008-06-16 7:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712170514.20465.zippel@linux-m68k.org \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox