From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86: fix ref-counting bug in change_page_attr()
Date: Mon, 17 Dec 2007 14:28:02 +0100 [thread overview]
Message-ID: <20071217132802.GD1870@elte.hu> (raw)
In-Reply-To: <47610AB5.76E4.0078.0@novell.com>
* Jan Beulich <jbeulich@novell.com> wrote:
> When either calling change_page_attr() with the default attributes
> pages in the direct mapping have and a page's attributes already were
> set to the default or when changing the attributes from one
> non-default value to another, the reference counting broke, leading to
> either premature restoration of a large page or missing the
> opportunity to do so.
>
> At the same time, make __PHYSICAL_MASK_SHIFT on 64-bits the value it
> architecturally ought to have.
hm, does this patch fix any real bug seen live? (if yes then do you have
links to it, etc?) It would be a v2.6.24 fix in theory but it looks too
dangerous for that. So i've queued it up for v2.6.25, for the time
being.
Ingo
next prev parent reply other threads:[~2007-12-17 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 9:34 [PATCH] x86: fix ref-counting bug in change_page_attr() Jan Beulich
2007-12-14 7:12 ` Jeremy Fitzhardinge
2007-12-14 8:38 ` Jan Beulich
2007-12-17 13:28 ` Ingo Molnar [this message]
2007-12-17 13:41 ` Jan Beulich
2007-12-17 14:34 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217132802.GD1870@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox